Open Bug 1278333 Opened 8 years ago Updated 2 years ago

All UIButton's in the navigation bar and menu panel are missing their highlighted state

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Unassigned)

Details

(Keywords: reproducible) 

Currently all navigation bar and menu panel are missing their highlighted state (i.e, the user touches the button with their finger down). We should set an image for the buttons selected highlight state as this is to be expected on the iOS platform.
tracking-fxios: --- → ?
Keywords: reproducible
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
tracking-fxios: ? → +
There are two things going on here: 

 * the down state images for the MenuItemViews are missing. This is ok, because we fallback to adding a tintColor. This is all done at https://github.com/mozilla/firefox-ios/blob/1f038995923d6f6cd753bef041d0b410c16a730d/Client/Frontend/Widgets/Menu/MenuViewController.swift#L211

 * the MenuItemViews are _not_ buttons, so don't have down states. (.Highlighted). This should probably be addressed, but there is no urgency for it right now.
Assignee: jhugman → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.