1278577 - RefTest structured log ids should be strings not arrays

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[James Graham [:jgraham]]

Although the original idea with structured logging was that the test ids could be tuples, it turns out that downstream consumers often don't work well with a string|tuple datatype e.g. it doesn't work well with a database. So we should stick to using pure-string identifiers.

Comment 1

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bffe1908035&selectedJob=22052052

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1278577 - Use simple strings as reftest test ids,

The idea of mozlog ids being tuples unfortunately didn't work so well
with external systems that found the tuple|string datatype difficult to
work with. Convert reftests to use simple ids of the form "<test url>
<comparison> <refurl>" e.g. "about:blank == data:text/html," instead of
tuples.

Review commit: https://reviewboard.mozilla.org/r/58238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58238/

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8760822 [details]
Bug 1278577 - Use simple strings as reftest test ids,

https://reviewboard.mozilla.org/r/58238/#review55150

Thanks, lgtm!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2836ccae457c
Use simple strings as reftest test ids, r=ahal

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2836ccae457c