Closed Bug 1278636 Opened 4 years ago Closed 4 years ago

Disable predictor prefetch on aurora 49

Categories

(Core :: Networking, defect)

49 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- disabled
firefox49 --- fixed

People

(Reporter: u408661, Assigned: u408661)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1268208 +++

Some regressions from bug 1016628 have still not been fixed. Let's disable on aurora again.
Attachment #8760860 - Flags: review?(honzab.moz)
Attachment #8760860 - Flags: review?(honzab.moz) → review+
Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch

Approval Request Comment
[Feature/regressing bug #]: 1016628
[User impact if declined]: known regressions
[Describe test coverage new/current, TreeHerder]: on beta (previously aurora)
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8760860 - Flags: approval-mozilla-aurora?
Is this enabled on beta 48 and aurora 49? I want to make sure we're disabling it in the correct versions since this request was just after the merge.
Flags: needinfo?(hurley)
No, this is only enabled on aurora 49. It was disabled for 48 back when that was aurora (bug 1268208).

I plan on landing a patch to ifdef the pref on m-c so we don't have to keep doing this dance every merge until I get the issues fixed (though hopefully that will be by the time 50 becomes aurora).
Flags: needinfo?(hurley)
Thanks, yes probably ifdef is the way to go here until you are sure.
Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch

Feature not ready, preffing it off for aurora 49. Please uplift.
Attachment #8760860 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
So closing as fixed.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
as a note, it appears we have fixed the perf issues on trunk (v.50)
You need to log in before you can comment on or make changes to this bug.