1278636 - Disable predictor prefetch on aurora 49

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[u408661]

+++ This bug was initially created as a clone of Bug #1268208 +++

Some regressions from bug 1016628 have still not been fixed. Let's disable on aurora again.

Comment 1

[u408661]

Attachment: disable-prefetch.patch

Comment 2

[u408661]

Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch

Approval Request Comment
[Feature/regressing bug #]: 1016628
[User impact if declined]: known regressions
[Describe test coverage new/current, TreeHerder]: on beta (previously aurora)
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this enabled on beta 48 and aurora 49? I want to make sure we're disabling it in the correct versions since this request was just after the merge.

Comment 4

[u408661]

No, this is only enabled on aurora 49. It was disabled for 48 back when that was aurora (bug 1268208).

I plan on landing a patch to ifdef the pref on m-c so we don't have to keep doing this dance every merge until I get the issues fixed (though hopefully that will be by the time 50 becomes aurora).

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks, yes probably ifdef is the way to go here until you are sure.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch

Feature not ready, preffing it off for aurora 49. Please uplift.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd0fbfbe790f

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

So closing as fixed.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

and the perf wins from this:
https://treeherder.mozilla.org/perf.html#/alerts?id=1583

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

as a note, it appears we have fixed the perf issues on trunk (v.50)