Closed Bug 1278664 Opened 5 years ago Closed 5 years ago
Chrome Docshells have Origin
Attributes .m Private Browsing Id set
Currently all DocShells opened by a private window have mPrivateBrowsingId set. The patch for this will only allow content Docshells to have a private browsing origin attribute.
Summary: Chrome Dochsells have OriginAttributes.mPrivateBrowsingId set → Chrome Docshells have OriginAttributes.mPrivateBrowsingId set
Comment on attachment 8761324 [details] [diff] [review] Bug1278664.patch You could just call UsePrivateBrowsing() in most places where mPrivateBrowsingId > 0 is used currently. And for mPrivateBrowsingId == 0 comparisons !UsePrivateBrowser() could be used. I guess only nsDocShell::GetUsePrivateBrowsing needs to do explicit mPrivateBrowsingId > 0; check. Using the method would make the code a bit easier to read. So, with that, r+. FWIW, UsePrivateBrowsing() is a helper method defined in nsILoadContext which nsDocShell extends. Not about this bug, but really odd to see nsDocShell::Destroy() to play with origin attributes.
Attachment #8761324 - Flags: review?(bugs) → review+
Attachment #8761324 - Attachment is obsolete: true
Attachment #8761591 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9fdca91d175e Chrome docshells can't have private browsing OriginAttribute. r=smaug
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/3fb62649e99a TabContext were not being passed the right PrivateBrowsingId r=baku,smaug
This was backed out from Firefox 49 in bug 1297687.
You need to log in before you can comment on or make changes to this bug.