Closed
Bug 1278668
Opened 9 years ago
Closed 9 years ago
Top bar bar should only appear on iPad devices in portrait/landscape layout
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: sleroux, Assigned: tlacroix)
References
Details
Attachments
(1 file)
The top tabs bar should only appear in in landscape/portrait iPad. For the most part this means showing the bar when the horizontal traitCollection is set to Regular. Note that iPhone landscape also has a regular horizontal size so we'll need to make sure this only shows for iPad devices.
Also consider the layouts when using split screen mode on iPad.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8761354 -
Flags: review?(sleroux)
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → tlacroix
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8761354 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1900
Left some feedback on the PR but works pretty well!
Attachment #8761354 -
Flags: feedback+
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8761354 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1900
Just one last nit to fix but looks good!
Attachment #8761354 -
Flags: review?(sleroux) → review+
|
|
Reporter | |
Comment 4•9 years ago
|
||
Resolved with patch on meta.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•