Two Coverity fixes for the JIT

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla50
coverity
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: CID 1286490, CID-1296728)

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Two Coverity fixes coming up.
(Assignee)

Comment 1

2 years ago
Created attachment 8761060 [details] [diff] [review]
(part 1) - Add a missing null check in PropertyTypeIncludes
Attachment #8761060 - Flags: review?(bhackett1024)
(Assignee)

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8761061 [details] [diff] [review]
(part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value

bhackett, I *think* this call is just for its side-effects and the return value
doesn't matter, but confirmation would be helpful. Thank you.
Attachment #8761061 - Flags: review?(bhackett1024)
Attachment #8761060 - Flags: review?(bhackett1024) → review+
Comment on attachment 8761061 [details] [diff] [review]
(part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value

Review of attachment 8761061 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the TemporaryTypeSet constructor will internally check for groups with unknown properties (which groups with unstable class/proto will have), so the rval isn't needed here.
Attachment #8761061 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1e5d75a2e9d6f46a48bc66c243dcfeb2cd40788
Bug 1278752 (part 1) - Add a missing null check in PropertyTypeIncludes. r=bhackett.

https://hg.mozilla.org/integration/mozilla-inbound/rev/87f4fe4848c26efe073ed77313aac00ffd437060
Bug 1278752 (part 2) - Make explicit the ignoring of a hasStableClassAndProto() return value. r=bhackett.

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1e5d75a2e9d
https://hg.mozilla.org/mozilla-central/rev/87f4fe4848c2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.