1278797 - Fix requests-menu-stack-trace direction in RTL locales

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[magicp]

Attachment: requests-menu-stack-trace-in-rtl.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160607071209

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Netmonitor
3. Go to any sites (e.g. https://bugzilla.mozilla.org)
4. Open requests-menu-stack-trace popup (mouse over on [JS] icon)


Actual results:

File name is not displayed fully, because ellipsis position is in file name side.


Expected results:

Change ellipsis position.

or... in case of the Browser console in RTL locale, direction is not RTL. If apply same specification to requests-menu-stack-trace, its direction should be LTR. Please refer to attached image.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

Jarda, this is related to the new feature you've
been working on. Can you please take a look?

Honza

Comment 2

[Jarda Snajdr [:jsnajdr]]

I'll be migrating the tooltip from XUL to HTML very soon (and maybe also to the frame.js React component), so I'll take care of this in the process.

Comment 3

[Jarda Snajdr [:jsnajdr]]

Attachment: Fix requests-menu-stack-trace direction in RTL locales

The issue was partially fixed when we converted the stacktrace tooltip from XUL to HTML in bug 1277264.

Now I'm adding the final step: add a "direction: ltr" rule to the stacktrace container element (.stack-trace-tooltip). I.e., the same thing that is set on the console output at [1].

[1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/webconsole.css#143

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/7fe9c07a21e9
Fix requests-menu-stack-trace direction in RTL locales. r=bgrins

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7fe9c07a21e9