Closed Bug 1278797 Opened 3 years ago Closed 3 years ago

Fix requests-menu-stack-trace direction in RTL locales

Categories

(DevTools :: Netmonitor, defect, P2)

defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: magicp.jp, Assigned: jsnajdr)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160607071209

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Netmonitor
3. Go to any sites (e.g. https://bugzilla.mozilla.org)
4. Open requests-menu-stack-trace popup (mouse over on [JS] icon)


Actual results:

File name is not displayed fully, because ellipsis position is in file name side.


Expected results:

Change ellipsis position.

or... in case of the Browser console in RTL locale, direction is not RTL. If apply same specification to requests-menu-stack-trace, its direction should be LTR. Please refer to attached image.
Has STR: --- → yes
Component: Untriaged → Developer Tools: Netmonitor
OS: Unspecified → All
Hardware: Unspecified → All
Thanks for the report!

Jarda, this is related to the new feature you've
been working on. Can you please take a look?

Honza
Flags: needinfo?(jsnajdr)
Priority: -- → P2
I'll be migrating the tooltip from XUL to HTML very soon (and maybe also to the frame.js React component), so I'll take care of this in the process.
Assignee: nobody → jsnajdr
Blocks: 1134073
Flags: needinfo?(jsnajdr)
The issue was partially fixed when we converted the stacktrace tooltip from XUL to HTML in bug 1277264.

Now I'm adding the final step: add a "direction: ltr" rule to the stacktrace container element (.stack-trace-tooltip). I.e., the same thing that is set on the console output at [1].

[1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/webconsole.css#143
Attachment #8775581 - Flags: review?(bgrinstead)
Attachment #8775581 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/7fe9c07a21e9
Fix requests-menu-stack-trace direction in RTL locales. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7fe9c07a21e9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.