127881 - View Menu: Messages: Threaded needs to be removed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[jglick]

Windows Build: 2002022503

The 3 Pane Mail Window, View: Messages: Threaded menu item needs to be removed 
for several reasons:

1. It behaves like a sort (radio menu group) and not an on/off (checkbox menu 
item) like it should.  The sort behavior is already covered by the View:Sort by: 
Thread menu, so this item is redundant.
2. It behaves like a sort, yet selecting it cause a checkmark to appear in front 
of it. Selecting the item again does NOT removed the checkmark like it should. 
User has to select another sort order to get out of this mode.
3. It is using a "T" mnemonic which is already being used by another menu item 
in this menu (Threads with Unread).

Comment 1

[jglick]

Nominating since menu item does not behave properly And causes a mnemonic 
conflict.

Comment 2

[:deanis74]

I meant to file this bug yesterday, but never got around to it.  My big
complaint is the second half of point 1, that it's confusing to have both this
menu item as well as View > Sort By > Thread.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Jen, did you want View | Ignore Threads to be all by itself, with a separator? 
I have a fix for this bug, either way.  Seth, do you care if I re-assign this to me?

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot after my fix.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix

Comment 6

[jglick]

Your screenshot is great. Thanks for fixing. I think its ok that its by itself 
since its a checkbox menu item and doesn't belong with the first group of radio 
items, and doesn't really belong with the actions at the bottom.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Sweet - reassigning to self.  ssu - r? seth - sr?

Comment 8

[Sean Su]

Comment on attachment 71605 [details] [diff] [review]
Fix

r=ssu

Comment 9

[David :Bienvenu]

Comment on attachment 71605 [details] [diff] [review]
Fix

ok, sr=bienvenu

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

changing to assigned, adding priority and tm.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 71605 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to 0.9.9 and the trunk.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

I'm marking this fixed, since it landed on the trunk and will be in 1.0.  I
don't it's necessary for 0.9.9 (since we've had it in the whole lifetime's
existence).

Comment 13

[Olga]

Verified on Win2K, Linux, Mac OSX - 03-04-2002 trunk.
New View|Messages menu items are implemented according to Comment #4.

Comment 14

[Peter Lairo]

I hope this is only a temporary workaround to a proper solution to threading
versus sorting.

The current state is still logically incorrect. Threading has little-to-nothing
to do with sorting, and therefore should not be in the "View / Sort by" list.

Please see bug 72493 for details. Particularly bug 72493 comment #15 and bug
72493 comment #28 and here: http://www.jwz.org/doc/threading.html

Therefore, when bug 72493 is fixed, the "fix" for this bug will need to be
reversed to the following:

1. Remove: View / Sort by  / *Thread*

2. Add:    View / Messages / *Threaded*

This bug should be clearly marked as a *workaround* until bug 72493 is fixed.

Comment 15

[jglick]

Peter, thats the plan. :-)

Comment 16

[Blake Ross]

Er...bug 72493 isn't nominated.  We can't seriously ship without any workaround
for this.  I apparently have no way to read my news threaded and sorted by date
anymore, which means Mozilla ceases to be a viable newsreader.  I have to ask
that we reopen this or commit to fixing bug 72493 for machv.  Am I just missing
something here?  Or how on earth does everyone else read news now?

Comment 17

[Blake Ross]

Okay, kerz points out I can get the old functionality back by clicking the
Threaded column icon. But it still doesn't make sense to me why this
functionality is no longer available in the menus, at least for this release.

Comment 18

[Blake Ross]

Now that I've made a total ass of myself...ok, it seems I was just having a
problem with one newsgroup, n.p.m.general, which also isn't showing me new
messages. I guess that one is corrupted somehow. (No matter what I do, I can't
get it to sort by date in threaded mode. It just sorts in random order). It
works fine in other newsgroups. Away I go...