Enable service worker notifications everywhere except for non-release B2G

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM: Push Notifications
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kitcambridge, Assigned: kitcambridge)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 unaffected, firefox48+ fixed, firefox49blocking fixed, firefox50 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Created attachment 8761213 [details] [diff] [review]
notifsEverywhere.patch

Already r+'ed by baku in bug 1278435, comment 10. Moving the patch out into a separate bug because this one needs to go through the uplift process and land everywhere.

Requesting tracking for 48 and 49 because we want to ship push in Android 48. Without this, a service worker could receive pushes, but not show any notifications.
Attachment #8761213 - Flags: review+

Comment 1

2 years ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5df0f767ed
Enable service worker notifications everywhere except for non-release B2G. r=baku
Comment on attachment 8761213 [details] [diff] [review]
notifsEverywhere.patch

Approval Request Comment
[Feature/regressing bug #]: Android push notifications.
[User impact if declined]: Service workers won't be able to show notifications to the user on Android release builds.
[Describe test coverage new/current, TreeHerder]: Covered by existing tests.
[Risks and why]: Low risk, since service worker notifications were already available in non-release builds.
[String/UUID change made/needed]: None.
Attachment #8761213 - Flags: approval-mozilla-beta?
Attachment #8761213 - Flags: approval-mozilla-aurora?
Whiteboard: btpp-active

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5a5df0f767ed
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8761213 [details] [diff] [review]
notifsEverywhere.patch

OK, let's ship that!
Thanks
Should be in 48 beta 2
Attachment #8761213 - Flags: approval-mozilla-beta?
Attachment #8761213 - Flags: approval-mozilla-beta+
Attachment #8761213 - Flags: approval-mozilla-aurora?
Attachment #8761213 - Flags: approval-mozilla-aurora+
tracking-firefox48: ? → +
tracking-firefox49: ? → blocking
(Assignee)

Comment 5

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/3dda03d4037e
status-firefox48: affected → fixed
(Assignee)

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/e50976a962c4
status-firefox49: affected → fixed
Thanks, Sylvestre!
You need to log in before you can comment on or make changes to this bug.