adjust ifdefs in Conversions.h:ToInt32 to catch clang-on-arm-generally

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The bug noted in ToInt32 doesn't just exist when compiling for
arm-darwin; it exists for ARM targets generally.  The ifdef should
reflect that.
(Assignee)

Comment 1

2 years ago
Created attachment 8761217 [details] [diff] [review]
adjust ifdefs in Conversions.h:ToInt32 to catch clang-on-arm-generally

It's unfortunate that compiling with clang has to disable the fast path for
this.  clang also chokes on the inline assembly.
Attachment #8761217 - Flags: review?(luke)
(Assignee)

Updated

2 years ago
Blocks: 1163171

Updated

2 years ago
Attachment #8761217 - Flags: review?(luke) → review+

Comment 2

2 years ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd25b06261c8
adjust ifdefs in Conversions.h:ToInt32 to catch clang-on-arm-generally; r=luke

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd25b06261c8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.