Closed
Bug 1278861
Opened 8 years ago
Closed 8 years ago
adjust ifdefs in Conversions.h:ToInt32 to catch clang-on-arm-generally
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The bug noted in ToInt32 doesn't just exist when compiling for
arm-darwin; it exists for ARM targets generally. The ifdef should
reflect that.
|
Assignee | |
Comment 1•8 years ago
|
||
It's unfortunate that compiling with clang has to disable the fast path for
this. clang also chokes on the inline assembly.
Attachment #8761217 -
Flags: review?(luke)
|
|
||
Updated•8 years ago
|
Attachment #8761217 -
Flags: review?(luke) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd25b06261c8
adjust ifdefs in Conversions.h:ToInt32 to catch clang-on-arm-generally; r=luke
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•