1278928 - Location bar marks an open and synced tab only as an already open one

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect, P3)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 48.0b1 build2 (20160606200529)
- 50.0a1 (2016-06-08)
- 49.0a2 (2016-06-08)
- 47.0 build3 (20160604131506)

[Affected platforms]:
- Windows 8.1 x64
- Windows 10 x86
- Mac OS X 10.9.5
- Ubuntu LTS 14.04 x64

[Steps to reproduce]:
1. Launch Firefox.
2. Sign in to Sync.
   - ensure that you have one tab synced from other devices
3. Click the location bar and type a word that matches your synced website.
   - observe the results displayed by the location bar drop down 
4. Open the synced website in a new tab.
5. In another new tab, type a word that matches your synced website.
   - observe the results displayed by the location bar drop down 

[Expected result]:
- (Step 3) The location bar drop down displays a result that is marked as a synced tab and also provides a link to the site in question
- (Step 5) The location bar drop down displays a result that is marked as a synced tab and also as an already open tab, providing a link to the site in question

[Actual result]:
- (Step 3) The location bar drop down displays a result that is marked as a synced tab also a link to the site in question
- (Step 5) The location bar drop down displays a result that is marked only as an already open tab, providing a link to the site in question - although the tab has both attributes: is a synced and an already open one.

[Regression range]:
- I will investigate this as soon as possible

Comment 1

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Back with updates for the [Regression range] field: this issue is also reproducing on 48.0a1 (2016-04-06)- when New Awesome Bar first landed, so this is NOT a regression.

Comment 2

[Andrew Overholt [:overholt]]

(In reply to Iulia Cristescu, QA [:IuliaC] from comment #1)
> Back with updates for the [Regression range] field: this issue is also
> reproducing on 48.0a1 (2016-04-06)- when New Awesome Bar first landed, so
> this is NOT a regression.

Can you please clarify when the change in functionality happened?

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Andrew Overholt [:overholt] from comment #2)
> (In reply to Iulia Cristescu, QA [:IuliaC] from comment #1)
> > Back with updates for the [Regression range] field: this issue is also
> > reproducing on 48.0a1 (2016-04-06)- when New Awesome Bar first landed, so
> > this is NOT a regression.
> 
> Can you please clarify when the change in functionality happened?

Hello! As I mentioned in Comment 1, this bug isn't a New Awesome Bar regression. However, I tested this scenario across Firefox builds and I noticed that before New Awesome Bar landing (2016-04-06), the issue is reproducible all the way back to Fx 29.0. 
Note: Till 45.0a1 (2015-11-12), location bar drop down doesn't mark in any way the synced tabs that matches with the typed sequence.

Comment 4

[Andrew Overholt [:overholt]]

Thank you for clarifying!

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Note that synced tabs in the awesome bar landed in bug 1210616 - this was close to the new awesomebar landing, but isn't strictly related to that.

I don't understand (3)

> [Expected result]:
> - (Step 3) The location bar drop down displays a result that is marked as a synced tab and also provides a link to the site in question
> [Actual result]:
> - (Step 3) The location bar drop down displays a result that is marked as a synced tab also a link to the site in question

They sound identical to me - could you please clarify?

Re (5), I'm fairly sure that it is by design that we prefer the "switch to tab" over the "synced tab" to avoid having too many duplicate entries (as dupes will cause other relevant entries to not appear, and switching to an already open tab seems preferable to opening a new identical tab)

Comment 6

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Mark Hammond [:markh] from comment #5)

> Note that synced tabs in the awesome bar landed in bug 1210616 - this was
> close to the new awesomebar landing, but isn't strictly related to that.

Yes, indeed, this issue is not related only to the New Awesome Bar, because it also implies data about user's synced tabs. But, as I mentioned in comment 3, till 45.0a1 (2015-11-12) - when Bug 1210616 fix landed, the issue is not related to Synced Tabs, as proof that location bar drop down doesn't mark in any way the synced tabs that match with the typed sequence.

> 
> I don't understand (3)
> 
> > [Expected result]:
> > - (Step 3) The location bar drop down displays a result that is marked as a synced tab and also provides a link to the site in question
> > [Actual result]:
> > - (Step 3) The location bar drop down displays a result that is marked as a synced tab also a link to the site in question
> 
> They sound identical to me - could you please clarify?

Yes, they are identical. I wanted to emphasize that the heart of the matter [1] isn't in this step (where expected = actual), but in step 5. 

> 
> Re (5), I'm fairly sure that it is by design that we prefer the "switch to
> tab" over the "synced tab" to avoid having too many duplicate entries (as
> dupes will cause other relevant entries to not appear, and switching to an
> already open tab seems preferable to opening a new identical tab)

I am aware that it is desired to avoid dupes. 
[1] What I wanted to highlight through this bug is_not the need for another drop down entry (hence not for a dupe), but for an additional indication about the matched location bar result -> I am not talking about adding another link (which opens the same tab) besides "Switch to tab" link; I mean that location bar drop down should display a complete state of the tab in question and, of course, one single link to it, in order to avoid any user confusion about the concerned tab.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we want switch to tab to always win over remote tab, we won't add noise (like a second indicator).