1279046 - [Disco Pane] Expose onOperationCancelled event to content

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Stuart Colville [:muffinresearch]]

If a user installs an add-on via the new discovery pane and then clicks remove in about:addons#Extensions we get an onUninstalling event notification with needsRestart=true. 

If the user clicks undo in the about:addons#Extensions UI we don't get an event telling us that the user has cancelled the uninstallation. 

To fix this we'd need the onOperationCancelled event to be exposed to content alongside the other AddonListener events here: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/addonManager.js#237

Once we have the onOperationCancelled event we can show the needsRestart UI and remove it when recieving a notice that the pending uninstall event has been cancelled.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1279046 Expose onOperationCancelled to a.m.o

Review commit: https://reviewboard.mozilla.org/r/60548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60548/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8764979 [details]
Bug 1279046 Expose onOperationCancelled to a.m.o

https://reviewboard.mozilla.org/r/60548/#review57438

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/336e3e8c5ed2
Expose onOperationCancelled to a.m.o r=rhelmer

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/336e3e8c5ed2