127907 - Remove dead string code

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Alec Flett]

So my little find-unused-exports tool has found two types of functions that we
can clean up:
1) singular uses of a particular string function. In almost every one of these
cases, the consumer is doing the wrong thing and ending up using some API they
shouldn't.

for example
nsString value(...);
value.StripChars(".");

this is lame because "." is a cstring, so they could be using NS_LITERAL_STRING,
but even worse is that this is a single-character string, so they could be saying
value.StripChar(PRUnichar('.'));

2) Methods that are simply never called.. for instance CompressSet() is never
called outside of nsString2.cpp

In an effort to continue cleaning up old string code, I've gone and cleaned up
the consumers of 1) above, and removed the relevant methods from 2)

Patch forthcoming.

Comment 1

[Alec Flett]

Attachment: clean up nsString first

I first tackled nsString.. reviews?

This will make it much easier to move the code to nsAString-based stuff,
because there will be less methods to migrate.

Comment 2

[Alec Flett]

cc dp for reviews as well - this is a code space win, as we're removing lots of
dead code.

Comment 3

[jag (Peter Annema)]

Nominating for mozilla1.0, nsbeta1

Comment 4

[Alec Flett]

jag: so does that mean you'll review this? :)
dp: can you r= this?

Comment 5

[Alec Flett]

by the way, I've now tested this on windows, linux, and mac. No problems.

Comment 6

[Suresh Duddi (gone)]

Comment on attachment 71539 [details] [diff] [review]
clean up nsString first

r=dp

Comment 7

[jag (Peter Annema)]

Comment on attachment 71539 [details] [diff] [review]
clean up nsString first

sr=jag

Comment 8

[Alec Flett]

Attachment: now update nsCString

Another patch, this time I cleaned up nsCString

Can I get another r=dp, sr=jag? Again, the patches are pretty mechanical.

Comment 9

[Suresh Duddi (gone)]

Comment on attachment 72173 [details] [diff] [review]
now update nsCString

r=dp

Comment 10

[jag (Peter Annema)]

Comment on attachment 72173 [details] [diff] [review]
now update nsCString

When converting from |char| to |PRUnichar| and vice versa you need to do a
|unsigned char| cast in between, to protected against signed expansion where
|char| is signed. Perhaps we should put some helper functions up somewhere?

Other than that, sr=jag

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 71539 [details] [diff] [review]
clean up nsString first

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 72173 [details] [diff] [review]
now update nsCString

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Jaime Rodriguez, Jr.]

nsbeta1- per ADT/Embed triage.

Comment 14

[Alec Flett]

too late, it's been fixed.