1279120 - ContentSearchUI.js leaks a blob URL when you change default search engine

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

ContentSearchUI.js uses createObjectURL(), but never calls revokeObjectURL().  This is most noticeable when you have an about:newtab running the search box and then change your default search engine.  It drops the reference to the old default search icon, but fails to revoke the URL.  So the blob URL leaks until the about:newtab is closed.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Call revokeObjectURL() on search engine icon blob URLs. r=adw

Drew, this patch just calls revokeObjectURL() on the icon URLs when we no longer need them.  There is no harm in calling it if the URL was not created with createObjectURL().  It fixes the blob URL leak in my local testing.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8761445 [details] [diff] [review]
Call revokeObjectURL() on search engine icon blob URLs. r=adw

Review of attachment 8761445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Sorry this took so long.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0d6274311d4
Call revokeObjectURL() on search engine icon blob URLs. r=adw

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f0d6274311d4

Comment 5

[Subhrajyoti Sen]

Verified as RESOLVED on Firefox Aurora 50.0a2(2016-09-09) using Linux Mint 18

Comment 6

[Subhrajyoti Sen]

Verified as RESOLVED on Firefox Aurora 50.0a2(2016-09-09) using Linux Mint 18