1279131 - Consider using android::SurfaceTexture for sharing content-painted textures to the Compositor on Android

Status: RESOLVED DUPLICATE of bug 1092294

(Core :: Graphics: Layers, defect, P3)

Description

[Sotaro Ikeda [:sotaro OOO until July/21]]

SurfaceTexture owns andoroid::GraphicBuffer(gralloc), it could have better performance for rendering to OpenGL compositor than MemoryTextureData.

This was originally motivated by the SurfaceTexture "single buffered mode".

  https://developer.android.com/reference/android/graphics/SurfaceTexture.html#SurfaceTexture%28int,%20boolean%29

Comment 1

[Sotaro Ikeda [:sotaro OOO until July/21]]

SurfaceTexture has 2 ways of usages.
-[1] android modules rendering via ANativeWindow.
 + Used for video decoding, camera rendering, OpenGL rendering.
 + Fiefox android use it for video decoding like the following.  
  > https://github.com/sotaroikeda/firefox-diagrams/blob/master/gfx/gfx_AndroidSurfaceTextureData_47.pdf

-[2] Lock ANativeWindow, get drawing buffer and drawing into the buffer.
 + If we could use SurfaceTexture "single buffered mode",
   it seems possible use SurfaceTexture as andoroid::GraphicBuffer(gralloc).

Comment 2

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: wip patch - Use SurfaceTexture as drawing buffer

The patch creates SurfaceTexture as "single buffered mode". But SurfaceTexture seems not work as using single buffer. Then rendering was a bit broken.

Comment 3

[Sotaro Ikeda [:sotaro OOO until July/21]]

From attachment 8761462 [details] [diff] [review], I saw the following problem.
- SurfaceTexture has "single buffered mode" since KK(API 19).
  But SurfaceTexture does not work as to own single buffer. It worked as double buffering.
  It caused rendering break.
  BufferQueue's min max buffer count is always more than 2. It is 2 also in "single buffered mode".
  Therefore "single buffered mode" SurfaceTexture could allocate 2 buffers.
  The meaning of "single buffered mode" is not clear, but "single buffered mode" seems broken on android.
  http://androidxref.com/6.0.1_r10/xref/frameworks/native/libs/gui/BufferQueueCore.cpp#160

- Allocating and deallocating SurfaceTexture rapidly seemed to cause out of file descriptor.

- When SurfaceTexture was locked, it needs to pass invalid region. If the invalid region is not
  passed, it expects that whole locked buffer is rendered during the locking period.

Comment 4

[Sotaro Ikeda [:sotaro OOO until July/21]]

From comment 3, attachment 8761462 [details] [diff] [review] seems not a way to go. But it might help for another investigations.

Comment 5

[Sotaro Ikeda [:sotaro OOO until July/21]]

chromium has a bug to add "single buffer SurfaceTexture mode".
 https://codereview.chromium.org/1419623008/

Comment 6

[Jamie Nicol [:jnicol]]

I just noticed this is a duplicate of bug 1092294