1279206 - Password icons

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[:Paolo Amadini]

As part of the popup notifications redesign, we are converting the password icons from PNG to SVG. The new icons are specified in the front-end theme, and the old "key" icons are being removed from Toolkit.

These references will no longer be valid:

http://mxr.mozilla.org/comm-central/search?string=chrome%3A//mozapps/skin/passwordmgr/

To solve this, the old PNG icons or the new SVG ones could be moved to the SeaMonkey theme.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1279206-PasswordIcons.patch

Paolo, thanks for letting us know about the change.

Philip, I took the Windows and OSX png icons but not the linux ones. key.png and [e-mail] seem to be unused in the themes. Shopuld we keep them?

Comment 2

[Philip Chee]

Comment on attachment 8763344 [details] [diff] [review]
1279206-PasswordIcons.patch

> Philip, I took the Windows and OSX png icons but not the linux ones.
Yes. I think we use the windows images for linux.

> key.png
> and [e-mail] seem to be unused in the themes. Shopuld we keep them?
We should keep [e-mail] assuming we will support HiDPI screens in the future. key.png is small enough that it doesn't make a difference and we don't package it anyway.

> diff --git a/suite/themes/classic/communicator/passwordmgr/key-16.png
Please put the PNGs in /suite/themes/classic/communicator/icons/ instead.
(and /suite/themes/classic/mac/communicator/icons/)

> diff --git a/suite/themes/modern/communicator/passwordmgr/key-16.png
All the changes in modern are unnecessary. Please revert.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1279206-PasswordIcons-V2.patch

V2 but with modern still in. Why isn't modern not needing the changes?

Comment 4

[Philip Chee]

> V2 but with modern still in. Why isn't modern not needing the changes?
Modern already has key-16.png, key-64.png, and key.png. I don't see why you need additional copies of these three files.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1279206-PasswordIcons-V3.patch

You are right. Sorry I missed it. I overlooked that the png files were not fetched from the toolkit directory. 

Modern and classic are now a bit inconsistent. Modern is mozapps/passwordmgr and classic icons. Should they be moved?

Comment 6

[Philip Chee]

> Modern and classic are now a bit inconsistent. Modern is mozapps/passwordmgr
> and classic icons. Should they be moved?

No. Modern is (or should be built) as a third party theme. Hence Modern controls /global/ /mozapps/ and all other toolkit theme locations.

Comment 7

[Philip Chee]

Comment on attachment 8764366 [details] [diff] [review]
1279206-PasswordIcons-V3.patch

Thanks!

Comment 8

[Frank-Rainer Grahl (:frg)]

Done

https://hg.mozilla.org/comm-central/rev/b82327300d15