Move Tabs component to shared/components

RESOLVED FIXED in Firefox 50

Status

()

Firefox
Developer Tools: Framework
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Honza, Assigned: Honza)

Tracking

unspecified
Firefox 50
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Tabs component in jsonview/components/reps should be moved to shared/components/tabs

Honza
(Assignee)

Updated

a year ago
Assignee: nobody → odvarko
Blocks: 1259819
Whiteboard: [devtools-html]
Blocks: 1263741
Whiteboard: [devtools-html] → [devtools-html] [triage]
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
(Assignee)

Comment 1

a year ago
Created attachment 8761573 [details] [diff] [review]
bug1279215.patch

@Patrick, I am moving the Tabs component from jsonview to shared components directory (it's related to the bug 1259819).

Honza
Attachment #8761573 - Flags: review?(pbrosset)
Comment on attachment 8761573 [details] [diff] [review]
bug1279215.patch

Review of attachment 8761573 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8761573 - Flags: review?(pbrosset) → review+
(Assignee)

Comment 3

a year ago
Thanks for quick review.

Yet one try push to make sure all's good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=95433f1ca851

Honza
(Assignee)

Comment 4

a year ago
Created attachment 8761584 [details] [diff] [review]
bug1279215.patch

One more module path fixed.

New try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9b109c3d768

Honza
Attachment #8761584 - Flags: review+
(Assignee)

Updated

a year ago
Attachment #8761573 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 5

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/29e262587b6b
Move Tabs component to shared/components; r=pbro
Keywords: checkin-needed

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/29e262587b6b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.