1279224 - Remove the Sync promotion in the add-on install doorhanger

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[John Gruen [:jgruen]]

Attachment: Screenshot 2016-06-08 16.06.45.png

In add-on (Test Pilot) related user testing, we saw the sync promotion cause a lot of confusion. 

If they have not set up Sync, at the bottom of the door hanger appears a panel that promotes Sync with a link to SUMO.

Clicking the link closes the door hanger, and disrupts the add-on's install flow.

We should remove this marketing messaging here. There are less confusing ways to market sync throughout the product.

Comment 1

[Andy McKay]

Is there some setting or condition that makes you get that sync promotion? +1 on removing it too.

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Andy McKay [:andym] from comment #1)
> Is there some setting or condition that makes you get that sync promotion?
> +1 on removing it too.

I think it's here:

> If they have not set up Sync, at the bottom of the door 
> hanger appears a panel that promotes Sync with a link to SUMO.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

There are 2 addon-related promo messages - when Sync isn't configured we show the one attached by John, and if Sync is configured but addon syncing is disabled, we show one that says "You can use your %S account to synchronize add-ons across multiple devices." which (I think) has the same basic flow.

Do we want to kill that one too? (ni? both John and Ryan, but I'll take an answer from anyone ;)

Comment 4

[Ryan Feeley [:rfeeley]]

John says kill both and I agree.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

We've already killed the promo from the password doorhanger and after killing these 2 only 1 remains - on the "edit bookmark" popup. Do we want to keep that too or shall we just kill it and remove the promo feature entirely?

Comment 6

[Mark Hammond [:markh] [:mhammond]]

John said "kill bookmark promo too" - patch forthcoming. Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=409f1bec8046&selectedJob=22440172

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1279224 - remove all Sync promotions from doorhangers.

Review commit: https://reviewboard.mozilla.org/r/59364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59364/

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8762913 [details]
Bug 1279224 - remove all Sync promotions from doorhangers.

https://reviewboard.mozilla.org/r/59364/#review56592

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94c2f240dffa
remove all Sync promotions from doorhangers. r=adw

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94c2f240dffa

Comment 11

[Sayed [:LiquidO2]]

I have successfully reproduced this bug in firefox nightly 50.0a1(2016-06-09) with elementary OS 0.3.2 Freya 64 bit	

I have verified this bug as fixed in Latest nighly 50.0a1
Build ID 	20160622030210
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160622]

Comment 12

[Muktasib Un Nur]

I have reproduced this bug with Firefox Nightly 50.0a1 (2016-06-09)
Build ID: 20160609130607
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
in Windows 8.1, 64-bit.

Verified as fixed with Firefox Nightly 50.0a1 (2016-06-22)
Build ID: 20160622030210
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160622]

Comment 13

[John Gruen [:jgruen]]

Awesome! Thanks for working on this.

Comment 14

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8762913 [details]
Bug 1279224 - remove all Sync promotions from doorhangers.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Per comment 0 - poor UX for testpilot and various other features.
[Describe test coverage new/current, TreeHerder]: Tests pass
[Risks and why]: Low risk, failure will be obvious enough to make it a relatively low-risk early Aurora uplift
[String/UUID change made/needed]: Strings removed.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Which branches are affected? Does this need to go into 48 as well?

Comment 16

[Mark Hammond [:markh] [:mhammond]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #15)
> Which branches are affected? Does this need to go into 48 as well?

All branches are affected. It's bad UX as when a user clicks on a promotion for Sync, the entire doorhanger is dismissed and the user is confused about what happened to their addon install or saved password. On one hand we've lived with it for quite some time, but on the other hand I think we should fix these kinds of warts ASAP.

I didn't request 48 uplift in an attempt to be excessively conservative, but I believe UX jgruen would buy you a beer if we took it there :)

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Sylvestre, some risk here, what do you think about this for beta 5?

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Beta 6 is on me now, Mark can you request uplift?

Comment 19

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8762913 [details]
Bug 1279224 - remove all Sync promotions from doorhangers.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Per comment 0 - poor UX for testpilot and various other features.
[Describe test coverage new/current, TreeHerder]: Tests pass
[Risks and why]: Low risk, failure will be obvious enough to make it a relatively low-risk early Aurora uplift
[String/UUID change made/needed]: Strings removed.

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8762913 [details]
Bug 1279224 - remove all Sync promotions from doorhangers.

Let's uplift this for beta 6. We likely want to make sure to test in beta after it lands to see that the doorhangers still work.

Comment 21

[Carsten Book [:Tomcat]]

need l10n approval before 
at least i got * File used for localization (browser/locales/en-US/chrome/browser/browser.properties) altered in this changeset *
remote: 
remote: This repository is string frozen. Please request explicit permission from
remote: release managers to break string freeze in your bug.
remote: If you have that explicit permission, denote that by including in
remote: your commit message l10n=...
remote: *************************************************************


during uplift to aurora

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Mark, could you propose a new patch which will keep the string in aurora & beta? This is the usual workflow for l10n. Flod can sign off

Comment 23

[Francesco Lodolo [:flod]]

(In reply to Sylvestre Ledru [:sylvestre] [PTO until July 18th] from comment #22)
> Mark, could you propose a new patch which will keep the string in aurora &
> beta? This is the usual workflow for l10n. Flod can sign off

Yes please. Removing strings creates unnecessary noise, so it would be ideal to let the change to browser.properties ride the trains.

Comment 24

[Mark Hammond [:markh] [:mhammond]]

Attachment: Aurora/Beta version of the patch - no string removals

Version of the patch without the string removals. Same approval request as from comment 19:

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Per comment 0 - poor UX for testpilot and various other features.
[Describe test coverage new/current, TreeHerder]: Tests pass
[Risks and why]: Low risk, failure will be obvious enough to make it a relatively low-risk early Aurora uplift
[String/UUID change made/needed]: None in this version.

Comment 25

[Gerry Chang [:gchang]]

Comment on attachment 8767524 [details] [diff] [review]
Aurora/Beta version of the patch - no string removals

Review of attachment 8767524 [details] [diff] [review]:
-----------------------------------------------------------------

Polish an UX behavior. Take it in 48 beta 6 and aurora.

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a8e8182cf000

but has problems to apply to beta:

grafting 352474:a8e8182cf000 "Bug 1279224 - remove all Sync promotions from doorhangers (aurora/beta version). r=adw, a=lizzard"
merging browser/base/content/browser.css
merging browser/base/content/browser.xul
merging browser/base/content/popup-notifications.inc
merging browser/base/content/urlbarBindings.xml
merging browser/components/nsBrowserGlue.js
merging browser/themes/linux/browser.css
merging browser/themes/osx/browser.css
merging browser/themes/windows/browser-aero.css
merging browser/themes/windows/browser.css
warning: conflicts while merging browser/themes/linux/browser.css! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/osx/browser.css! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/windows/browser.css! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

mark can you take a look ?

Comment 27

[Mark Hammond [:markh] [:mhammond]]

Attachment: Beta version of the patch (no strings removed, css rebased)

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Per comment 0 - poor UX for testpilot and various other features.
[Describe test coverage new/current, TreeHerder]: Tests pass
[Risks and why]: Low risk, failure will be obvious enough to make it a relatively low-risk early Beta uplift
[String/UUID change made/needed]: None in this version.

Comment 28

[Gerry Chang [:gchang]]

Comment on attachment 8767790 [details] [diff] [review]
Beta version of the patch (no strings removed, css rebased)

Review of attachment 8767790 [details] [diff] [review]:
-----------------------------------------------------------------

Take it in 48 beta 6

Comment 29

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/274a291aa2c8

Comment 30

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 50.0a1 (2016-06-09) on Ubuntu 14.04, 64 bit!

The bug's fix is now verified on latest Realease 48.0,Beta 49.0b3, Aurora 50.0a2.

Realease 48.0:
Build ID 	20160728204513
User Agent 	Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

Beta 49.0b3:
Build ID 	20160811031722
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

Aurora 50.0a2:
Build ID 	20160812004003
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

[testday-20160812]

Comment 31

[Rezaul Huque Nayeem]

Reproduced this bug in firefox nightly 50.0a1 (2016-06-09) as comment 0 with windows 10(64 bit)

Verified this bug as fixed with latest firefox release 48.0 (Build ID: 20160726073904)
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

latest firefox Beta 49.0b3 (Build ID: 20160811031722)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

latest firefox aurora 50.0a2 (Build ID: 20160812004003)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0