Closed
Bug 1279232
Opened 8 years ago
Closed 8 years ago
Remove passwordmgr key-16.png from mobile theme
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Gijs, Assigned: bdave, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
|
1.51 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Bug 1274480 removed this from all the desktop themes. I suspect mfinkle kept this when making the mobile theme in order to pass the caps test that relied on it. Aforementioned bug changes said test to rely on something else (stopgap fix, I'll file another bug to fix properly) and so I suspect the directory etc. can be removed from the mobile theme. If so this is likely good first bug. Ni mfinkle to confirm.
Flags: needinfo?(mark.finkle)
|
Reporter | |
Updated•8 years ago
|
Product: Firefox → Firefox for Android
|
||
Comment 1•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #0) > Bug 1274480 removed this from all the desktop themes. I suspect mfinkle kept > this when making the mobile theme in order to pass the caps test that relied > on it. Exactly. The file can be removed if the test no longer requires it.
Flags: needinfo?(mark.finkle)
|
|
Reporter | |
Updated•8 years ago
|
Mentor: gijskruitbosch+bugs
Summary: Remove passwordmgr key-16.png from mobile theme if it is unused → Remove passwordmgr key-16.png from mobile theme
Whiteboard: [good first bug]
|
|
Reporter | |
Comment 2•8 years ago
|
||
This will need to remove the "passwordmgr" directory in toolkit/themes/mobile/mozapps/ . It will also need to remove this line: http://searchfox.org/mozilla-central/rev/8f19409ff1e36ab98d0f8dc1c8c0f75357bf625a/toolkit/themes/mobile/jar.mn#60 from toolkit/themes/mobile/jar.mn .
|
|
Reporter | |
Updated•8 years ago
|
Mentor: margaret.leibovic
|
Assignee | |
Comment 3•8 years ago
|
||
Hi Margaret, Please review and advice if any changes needed.
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8762719 [details] [diff] [review] 1279232.patch Review of attachment 8762719 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine to me, but Gijs should also review.
Attachment #8762719 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Updated•8 years ago
|
Assignee: nobody → bhavindave88
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8762719 [details] [diff] [review] 1279232.patch Review of attachment 8762719 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me!
Attachment #8762719 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/22add247f72f Remove passwordmgr key-16.png from mobile theme. r=gijs
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22add247f72f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•