1279306 - Switch the Android server URL to the prod push server

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler (ex-Mozilla)]

http://searchfox.org/mozilla-central/rev/8f19409ff1e36ab98d0f8dc1c8c0f75357bf625a/mobile/android/app/mobile.js#896 currently points to "stage", but it should be "prod".

Requesting tracking for Fennec 48. We'll need to uplift this to Beta.

Comment 1

[Lina Butler (ex-Mozilla)]

The prod URL prefix is "https://updates.push.services.mozilla.com/v1/gcm/...".

Comment 2

[Lina Butler (ex-Mozilla)]

Sounds like we'll need a new MOZ_ANDROID_GCM_SENDERID, too.

Comment 3

[Lina Butler (ex-Mozilla)]

Jeremy, can you send me the new GCM sender IDs when it's convenient, please? We'll need to update them in configure.sh for each build here: https://dxr.mozilla.org/mozilla-central/source/mobile/android/branding

Comment 4

[Jeremy Orem [:oremj]]

Production is: 965234145045

Comment 5

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1279306 - Use the production push server URL on Android.

Review commit: https://reviewboard.mozilla.org/r/58918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58918/

Comment 6

[Lina Butler (ex-Mozilla)]

After updating the Google Play Services app, clobbering, and building, I'm able to receive notifications. https://jrconlin.github.io/WebPushDataTestPage shows that the production server is used for the push endpoints.

Comment 7

[:Margaret Leibovic]

Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

https://reviewboard.mozilla.org/r/58918/#review55856

I don't have enough context to know if you're missing something, but rubber stamp from me if you feel confident this works!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6ab97a7c56ee
Use the production push server URL on Android. r=margaret

Comment 9

[Lina Butler (ex-Mozilla)]

Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

Approval Request Comment
[Feature/regressing bug #]: Android push notifications.
[User impact if declined]: All push messages sent to Fennec will go through the staging server instead of production.
[Describe test coverage new/current, TreeHerder]: Manually verified per comment 6. QA will verify Beta once this is uplifted.
[Risks and why]: Low risk; the staging and production servers are running the same version (1.15.0).
[String/UUID change made/needed]: None.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ab97a7c56ee

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

This patch changes the URL to prod push server. Take it in beta & aurora.

Hi Ioana, can you help to verify this after uplifting the patch?

Comment 12

[Carsten Book [:Tomcat]]

has problems to uplift to aurora:

grafting 349979:6ab97a7c56ee "Bug 1279306 - Use the production push server URL on Android. r=margaret"
merging mobile/android/app/mobile.js
warning: conflicts while merging mobile/android/app/mobile.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 13

[Carsten Book [:Tomcat]]

(In reply to Carsten Book [:Tomcat] from comment #12)
> has problems to uplift to aurora:
> 
> grafting 349979:6ab97a7c56ee "Bug 1279306 - Use the production push server
> URL on Android. r=margaret"
> merging mobile/android/app/mobile.js
> warning: conflicts while merging mobile/android/app/mobile.js! (edit, then
> use 'hg resolve --mark')
> abort: unresolved conflicts, can't continue
> (use 'hg resolve' and 'hg graft --continue')

margaret, since kit is on pto could you take a look at this ? thanks

Comment 14

[Lina Butler (ex-Mozilla)]

Sorry about that. Fixed up and landed.

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/5fa8da372343
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/1c0fa79f1afd

Comment 15

[Ioana Chiorean]

Using this https://jrconlin.github.io/WebPushDataTestPage I got the right URL "https://updates.push.services.mozilla.com/v1/gcm/..." on all 4 versions of Fennec.