Closed Bug 1279306 Opened 5 years ago Closed 5 years ago

Switch the Android server URL to the prod push server

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla50
Tracking Status
firefox48 --- verified
firefox49 --- verified
fennec 48+ ---
firefox50 --- verified
firefox51 --- verified

People

(Reporter: lina, Assigned: lina)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/8f19409ff1e36ab98d0f8dc1c8c0f75357bf625a/mobile/android/app/mobile.js#896 currently points to "stage", but it should be "prod".

Requesting tracking for Fennec 48. We'll need to uplift this to Beta.
Whiteboard: btpp-active
Sounds like we'll need a new MOZ_ANDROID_GCM_SENDERID, too.
Jeremy, can you send me the new GCM sender IDs when it's convenient, please? We'll need to update them in configure.sh for each build here: https://dxr.mozilla.org/mozilla-central/source/mobile/android/branding
Flags: needinfo?(oremj)
Production is: 965234145045
Flags: needinfo?(oremj)
After updating the Google Play Services app, clobbering, and building, I'm able to receive notifications. https://jrconlin.github.io/WebPushDataTestPage shows that the production server is used for the push endpoints.
Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

https://reviewboard.mozilla.org/r/58918/#review55856

I don't have enough context to know if you're missing something, but rubber stamp from me if you feel confident this works!
Attachment #8761879 - Flags: review?(margaret.leibovic) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/6ab97a7c56ee
Use the production push server URL on Android. r=margaret
Status: NEW → ASSIGNED
Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

Approval Request Comment
[Feature/regressing bug #]: Android push notifications.
[User impact if declined]: All push messages sent to Fennec will go through the staging server instead of production.
[Describe test coverage new/current, TreeHerder]: Manually verified per comment 6. QA will verify Beta once this is uplifted.
[Risks and why]: Low risk; the staging and production servers are running the same version (1.15.0).
[String/UUID change made/needed]: None.
Attachment #8761879 - Flags: approval-mozilla-beta?
Attachment #8761879 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6ab97a7c56ee
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8761879 [details]
Bug 1279306 - Use the production push server URL on Android.

This patch changes the URL to prod push server. Take it in beta & aurora.

Hi Ioana, can you help to verify this after uplifting the patch?
Flags: needinfo?(ioana.chiorean)
Attachment #8761879 - Flags: approval-mozilla-beta?
Attachment #8761879 - Flags: approval-mozilla-beta+
Attachment #8761879 - Flags: approval-mozilla-aurora?
Attachment #8761879 - Flags: approval-mozilla-aurora+
has problems to uplift to aurora:

grafting 349979:6ab97a7c56ee "Bug 1279306 - Use the production push server URL on Android. r=margaret"
merging mobile/android/app/mobile.js
warning: conflicts while merging mobile/android/app/mobile.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(kcambridge)
tracking-fennec: ? → 48+
(In reply to Carsten Book [:Tomcat] from comment #12)
> has problems to uplift to aurora:
> 
> grafting 349979:6ab97a7c56ee "Bug 1279306 - Use the production push server
> URL on Android. r=margaret"
> merging mobile/android/app/mobile.js
> warning: conflicts while merging mobile/android/app/mobile.js! (edit, then
> use 'hg resolve --mark')
> abort: unresolved conflicts, can't continue
> (use 'hg resolve' and 'hg graft --continue')

margaret, since kit is on pto could you take a look at this ? thanks
Flags: needinfo?(margaret.leibovic)
Sorry about that. Fixed up and landed.

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/5fa8da372343
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/1c0fa79f1afd
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(kcambridge)
Using this https://jrconlin.github.io/WebPushDataTestPage I got the right URL "https://updates.push.services.mozilla.com/v1/gcm/..." on all 4 versions of Fennec.
Status: RESOLVED → VERIFIED
Flags: needinfo?(ioana.chiorean)
You need to log in before you can comment on or make changes to this bug.