1279362 - Don't use DebugOnly in js/public

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

DebugOnly is a bit of a pain to interface with other languages (eg Rust).
Although this specific use isn't a pain for Servo (since they have their own
custom rooting) being consistent in not using DebugOnly in all of js/public
seems easiest to maintain long term.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Don't use DebugOnly is js/public

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b1d590e99fb

Comment 3

[Nicolas B. Pierron [:nbp]]

Why would DebugOnly be a pain in the body of a function?

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8761841 [details] [diff] [review]
Don't use DebugOnly is js/public

Review of attachment 8761841 [details] [diff] [review]:
-----------------------------------------------------------------

This makes no sense to me. Let's discuss it.

Comment 5

[Anthony Ramine [:nox]]

DebugOnly is only a pain if it appears in a public interface as a field, or an argument, or as anything that would actually appear in our Rust bindings. Otherwise, we don't care about that.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Anthony Ramine [:nox] from comment #5)
> DebugOnly is only a pain if it appears in a public interface as a field, or
> an argument, or as anything that would actually appear in our Rust bindings.
> Otherwise, we don't care about that.

Ok, I've misunderstood! Let's close this bug.