1279459 - Console always empty in ES-es version

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect, P1)

Description

[Fernando García Gómez, stripTM]

Attachment: console.png

In linux nightly spanish-Spain location the console are alwais empty, nothing is logged.

The buttons Net, Css... change state, but the console remains empty.

Comment 2

[Julian Descottes [:jdescottes]]

When opening the webconsole we are getting the following stack trace :

> WebConsolePanel open failed. undefined: Unsupported modifier: Mayús
> console.error: 
>  WebConsolePanel open failed. undefined: Unsupported modifier: Mayús
> *************************
> A coding exception was thrown in a Promise resolution callback.
> See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
> 
> Full message: TypeError: panel is undefined
> Full stack: Toolbox.prototype.loadTool/onLoad/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:1278:13
> Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
> this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
> Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
> this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
> this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
> onIframeLoad@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/webconsole/panel.js:57:9
> EventListener.handleEvent*WebConsolePanel.prototype.open@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/webconsole/panel.js:55:7
> Toolbox.prototype.loadTool/onLoad@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:1262:19

Alex: Looks like this comes from the localization of a key-shortcut added in Bug 1268447. Probably webconsole.clear.key in devtools/client/locales/en-US/webconsole.properties. This shortcut uses the "Shift" modifier (Mayús in spanish).

Comment 3

[Julian Descottes [:jdescottes]]

Hi Ricardo, looks like you translated webconsole.clear.key in https://hg.mozilla.org/l10n-central/es-ES/rev/042b1dd68a7a . 
The modifier strings "Ctrl/Shift/Alt/Cmd" should not be translated here. Could you have a look?

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Moving to localization component, seems specific to that locale.

Comment 5

[RickieES aka Ricardo Palomares]

Hi,

Yep. It was not clear to me if those entries contained keycodes or descriptions, because of the "CmdOrCtrl" in this entry:

http://hg.mozilla.org/mozilla-central/file/tip/devtools/client/locales/en-US/webconsole.properties#l264

If other localizations fall in this same batch of entries, perhaps it should be needed to add some clarification to the localization note. On the other side, if it is just me, then it was just me. :-)

Comment 6

[RickieES aka Ricardo Palomares]

Fixed in central, as I haven't uplifted the localization to Aurora yet:

https://hg.mozilla.org/l10n-central/es-ES/rev/8a984bf9897f

Comment 7

[Fernando García Gómez, stripTM]

Attachment: console_post_patch.png

Comment 8

[Fernando García Gómez, stripTM]

Verified in 50.0a1 (2016-06-11), console works properly.

Thanks.