1279471 - Unable to remove items from History if the "Prevent this page from creating additional dialogs" checkbox was checked

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: if the prevent this page from creating additional dialogs checkbox is checked you are no longer able to delete items.mp4

[Affected versions]:
- Firefox 45.0 and up
- Activity Stream 1.0.19-dev

[Affected Platforms]:
- All Windows
- All Mac OS X
- All Linux

[Prerequisites]:
- Latest Activity Stream add-on version (1.0.19-dev) was previously installed on a clean profile.
- Have enough history so that the "Top Sites", "Highlights", "History" areas are populated with visited websites.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites. 
2. Click the Activity Stream button from the browser toolbar.
3. Hover an item from the Highlights section.
4. Expand the Highlight context menu and click "Delete from History".
5. When the dialog appears click "Cancel" and repeat step 4.
6. When the dialog appears check the "Prevent this page from creating additional dialogs" checkbox and click "Cancel".
7. Repeat steps 3 and 4.

[Expected result]:
The "Prevent this page from creating additional dialogs" checkbox should not be displayed.

[Actual result]:
After the checkbox is checked you are no longer able to remove items from History because no dialogs are created.

[Notes]:
- The issue is also reproducible in the New Tab page.
- After a page refresh you are again able to remove items from History, because the checkbox resets itself.
- Attached a screen recording of the issue.

Comment 1

[Paul Oiegas [:poiegas], PM for (Ecosystem QA, Services QA, WebCompat QA, Hubs QA teams)]

Filed in GitHub as https://github.com/mozilla/activity-stream/issues/832

Comment 2

[Ed Lee :Mardak]

The Test Pilot version is no more, and the system-addon version has an in-page modal dialog for confirmation.

Fixed by https://github.com/mozilla/activity-stream/pull/2749 uplifted in bug 1376984.
https://hg.mozilla.org/mozilla-central/rev/854faa727465

Comment 3

[Carmen Tataru [:ctataru], Ecosystem QA]

Marking as Verified as Activity Stream has been transitioned from an addon to a feature build in the browser.
The issue is not reproducible on the current version of the New Tab page.