Closed
Bug 1279476
Opened 8 years ago
Closed 8 years ago
Fix search arrow background styling in about:home and about:newtab
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
3.38 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
I think this actually fixes a bug, as the gradient is clipped at border-box rather than padding-box as currently written.
Attachment #8761996 -
Flags: review?(florian)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8761996 [details] [diff] [review]
patch
Review of attachment 8761996 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Dão Gottwald [:dao] from comment #0)
> I think this actually fixes a bug, as the gradient is clipped at border-box
> rather than padding-box as currently written.
I agree in theory, but when testing the patch and zooming on the submit button, I couldn't notice any difference. But it's cleaner anyway, so r=me.
Attachment #8761996 -
Flags: review?(florian) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
I think I actually saw a difference in the upper left corner of the button without zooming in. But it certainly is subtle, could also have been my imagination.
|
|
Assignee | |
Comment 3•8 years ago
|
||
And when I said "upper left corner" I meant the upper right corner.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/7f8f1d4b1de0
Fix search arrow background styling in about:home and about:newtab. r=florian
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•