1279586 - password manager notification access key

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[microrffr]

User Agent: Mozilla/5.0 (Android 6.0.1; Mobile; rv:50.0) Gecko/50.0 Firefox/50.0
Build ID: 20160608030219

Steps to reproduce:

log in to something
notification shows up about remembering password
press alt+r


Actual results:

focuses drop down arrow next to "Remember" button


Expected results:

activates "Remember" button

Comment 1

[Matthew N. [:MattN]]

This will likely be fixed by the redesign of the remember password prompt. Marking for fxprivacy so we can decide what to do with this bug.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Unfortunately this isn't yet fixed due to an access key conflict that went unnoticed. Patch incoming.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Fix the access key conflict in the password manager prompt (bug 1279586).

Review commit: https://reviewboard.mozilla.org/r/95038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95038/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8813600 [details]
Fix the access key conflict in the password manager prompt (bug 1279586).

https://reviewboard.mozilla.org/r/95038/#review95246

Looks good and works for me, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/966bed7e5627
Fix the access key conflict in the password manager prompt . r=johannh

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/966bed7e5627

Comment 7

[Francesco Lodolo [:flod]]

For future reference, you don't need to change the string ID if you're fixing a conflict in English. Each locales has its own accesskeys, and should already have them sorted out.

On the other hand, it would be great to use consistent naming to help tools.

Bad:
togglePasswordLabel=Show password
togglePasswordAccessKey2=h

Good:
togglePassword.label=Show password
togglePassword.accessKey=h

Comment 8

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 50.0a1 (2016-06-10) on Windows 8 , 64 Bit!

This bug's fix is verified with latest Beta!

Build   ID 20170320143328
User Agent Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
[bugday-20170322]