Closed
Bug 1279593
Opened 8 years ago
Closed 7 years ago
MSVC warns that some files should be compiled with /arch:avx
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ted, Assigned: emk)
Details
Attachments
(1 file)
I saw this scroll by in my Windows build. I didn't catch exactly which files it was griping about, but judging from this DXR search I suspect it's all files under media/libvpx: https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path:avx&redirect=true Conveniently sources.mozbuild has them grouped together: https://dxr.mozilla.org/mozilla-central/rev/3ccccf8e5036179a3178437cabc154b5e04b333d/media/libvpx/sources.mozbuild#85 So we probably just need to add something like: ``` for f in files['AVX2']: SOURCES[f].flags += '-arch:avx' ``` here: https://dxr.mozilla.org/mozilla-central/rev/3ccccf8e5036179a3178437cabc154b5e04b333d/media/libvpx/moz.build#28
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
C4752 may indicate actual performance problem (although I didn't verify): https://stackoverflow.com/questions/7839925/using-avx-cpu-instructions-poor-performance-without-archavx
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8874803 [details] Bug 1279593 - Add /arch:AVX or /arch:AVX2 to compile some files under media/libvpx. .mielczarek https://reviewboard.mozilla.org/r/146190/#review150872
Attachment #8874803 -
Flags: review?(ted) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/858813bdc9b4 Add /arch:AVX or /arch:AVX2 to compile some files under media/libvpx. r=ted.mielczarek
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/858813bdc9b4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•