1279593 - MSVC warns that some files should be compiled with /arch:avx

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I saw this scroll by in my Windows build. I didn't catch exactly which files it was griping about, but judging from this DXR search I suspect it's all files under media/libvpx:
https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path:avx&redirect=true

Conveniently sources.mozbuild has them grouped together:
https://dxr.mozilla.org/mozilla-central/rev/3ccccf8e5036179a3178437cabc154b5e04b333d/media/libvpx/sources.mozbuild#85

So we probably just need to add something like:
```
for f in files['AVX2']:
  SOURCES[f].flags += '-arch:avx'
```

here:
https://dxr.mozilla.org/mozilla-central/rev/3ccccf8e5036179a3178437cabc154b5e04b333d/media/libvpx/moz.build#28

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1279593 - Add /arch:AVX or /arch:AVX2 to compile some files under media/libvpx. .mielczarek

Review commit: https://reviewboard.mozilla.org/r/146190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146190/

Comment 2

[Masatoshi Kimura [:emk]]

C4752 may indicate actual performance problem (although I didn't verify):
https://stackoverflow.com/questions/7839925/using-avx-cpu-instructions-poor-performance-without-archavx

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8874803 [details]
Bug 1279593 - Add /arch:AVX or /arch:AVX2 to compile some files under media/libvpx. .mielczarek

https://reviewboard.mozilla.org/r/146190/#review150872

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/858813bdc9b4
Add /arch:AVX or /arch:AVX2 to compile some files under media/libvpx. r=ted.mielczarek

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/858813bdc9b4