Closed Bug 1279649 Opened 4 years ago Closed 3 years ago
The inspector-pane-toggle should be rotated 90 deg, when docking to side of browser and vertical mode
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20160610073607 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. about:home) 3. Open DevTools > Inspector 4. Dock to side of browser window 5. Narrow toolbox-container untill vertical mode Actual results: Collapse/Expand pane button is not vertical mode. This is a regression of Bug 1189492. Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3a87296fe4145138c2ce15512bb31f76fe869cb4&tochange=42fab251fe111d5f891c9bde0ee1fb6f7f946a50 Expected results: Collapse/Expand pane button should be vertical mode.
Whiteboard: [devtools-html] [triage]
https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/inspector.css#92 > .toolbarbutton-icon should be changed to ::before
Nice catch magicjp btw, thanks for filing!
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage] → [devtools-html]
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Thanks for the report and analyses! Patch attached. Honza
Attachment #8764276 - Flags: review?(ntim.bugs)
Thanks Tim! Honza
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/3724c3955693 Rotate inspector-pane-toggle 90 deg for vertical mode. r=ntim
Comment on attachment 8764276 [details] [diff] [review] bug1279649.patch Approval Request Comment [Feature/regressing bug #]: Bug 1266419 [User impact if declined]: Inspector pane button is rotated the wrong way round when the sidebar is the displayed under the main panel [Describe test coverage new/current, TreeHerder]: in Nightly [Risks and why]: Low, 1 line CSS fix [String/UUID change made/needed]: no
Attachment #8764276 - Flags: approval-mozilla-aurora?
Comment on attachment 8764276 [details] [diff] [review] bug1279649.patch Regression from 49, fix looks simple, please uplift
Attachment #8764276 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reproduced with 50.0a1 from 2016-06-10 under Windows 10 64-bit. Verified fixed with latest Aurora 49.0a2 and Nightly 50.0a1, across platforms .  Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.11.1
You need to log in before you can comment on or make changes to this bug.