Closed Bug 1279649 Opened 4 years ago Closed 3 years ago

The inspector-pane-toggle should be rotated 90 deg, when docking to side of browser and vertical mode

Categories

(DevTools :: Inspector, defect, P1)

defect

Tracking

(firefox49 verified, firefox50 verified)

VERIFIED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox49 --- verified
firefox50 --- verified

People

(Reporter: magicp.jp, Assigned: Honza)

References

Details

(Whiteboard: [devtools-html])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160610073607

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Inspector
4. Dock to side of browser window
5. Narrow toolbox-container untill vertical mode


Actual results:

Collapse/Expand pane button is not vertical mode. This is a regression of Bug 1189492.

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3a87296fe4145138c2ce15512bb31f76fe869cb4&tochange=42fab251fe111d5f891c9bde0ee1fb6f7f946a50


Expected results:

Collapse/Expand pane button should be vertical mode.
Blocks: 1266419
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [devtools-html] [triage]
Flags: needinfo?(odvarko)
Nice catch magicjp btw, thanks for filing!
Flags: qe-verify+
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage] → [devtools-html]
Priority: -- → P2
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Attached patch bug1279649.patchSplinter Review
Thanks for the report and analyses!

Patch attached.

Honza
Flags: needinfo?(odvarko)
Attachment #8764276 - Flags: review?(ntim.bugs)
Attachment #8764276 - Flags: review?(ntim.bugs) → review+
Thanks Tim!

Honza
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/3724c3955693
Rotate inspector-pane-toggle 90 deg for vertical mode. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3724c3955693
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8764276 [details] [diff] [review]
bug1279649.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1266419
[User impact if declined]: Inspector pane button is rotated the wrong way round when the sidebar is the displayed under the main panel
[Describe test coverage new/current, TreeHerder]: in Nightly
[Risks and why]: Low, 1 line CSS fix
[String/UUID change made/needed]: no
Attachment #8764276 - Flags: approval-mozilla-aurora?
Comment on attachment 8764276 [details] [diff] [review]
bug1279649.patch

Regression from 49, fix looks simple, please uplift
Attachment #8764276 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reproduced with 50.0a1 from 2016-06-10 under Windows 10 64-bit.
Verified fixed with latest Aurora 49.0a2 and Nightly 50.0a1, across platforms [1].

[1] Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.11.1
Status: RESOLVED → VERIFIED
QA Whiteboard: [qe-dthtml]
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.