Closed Bug 1279651 Opened 4 years ago Closed 4 years ago

The show-all button overlaps on inspector-breadcrumbs-toolbar

Categories

(DevTools :: Inspector: Fonts, defect)

defect
Not set

Tracking

(firefox47 affected, firefox48 affected, firefox49 affected, firefox50 verified)

VERIFIED FIXED
Firefox 50
Tracking Status
firefox47 --- affected
firefox48 --- affected
firefox49 --- affected
firefox50 --- verified

People

(Reporter: magicp.jp, Assigned: jyeh)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160610073607

Steps to reproduce:

1. Start Nightly
2. Enable Font Inspector (about:config > devtools.fontinspector.enabled = true)
3. Go to any sites (e.g. about:home)
4. Open DevTools > Inspector > Font Inspector
5. Click Collapse Pane button


Actual results:

The show-all button stays after collapsing sidebar panel.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=de45c37454922316fb452f90b11f3b24ef6956dc&tochange=54bf7536f7006f279889b0abf9ab7deeb532e63c


Expected results:

The show-all button collapses with same as sidebar panel.
Blocks: 1238133
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Font Inspector
OS: Unspecified → All
Hardware: Unspecified → All
In RTL locales
Blocks: dt-rtl
Whiteboard: [good first bug][lang=css]
Will anyone review this patch for me? Thanks!
Assignee: nobody → jyeh
Comment on attachment 8765345 [details] [diff] [review]
0001-Bug-1279651-The-show-all-button-overlaps-on-inspecto.patch

Hi Tim,

I am not sure who can do the review for this bug. If you are not available, it's fine to forward to others :)

Thanks!
Attachment #8765345 - Flags: review?(ntim.bugs)
Comment on attachment 8765345 [details] [diff] [review]
0001-Bug-1279651-The-show-all-button-overlaps-on-inspecto.patch

Review of attachment 8765345 [details] [diff] [review]:
-----------------------------------------------------------------

Seems straightforward enough, thanks !
Attachment #8765345 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/3bde90c197be
The show-all button overlaps on inspector-breadcrumbs-toolbar
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3bde90c197be
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Does not fix in RTL locales. How about this?
Attached image rtl-screenshot.png
(In reply to magicp from comment #8)
> Created attachment 8767412 [details]
> rtl-screenshot.png

This is a separate issue, so I filed bug 1283998
I have reproduced this bug in firefox nightly 50.0a1 (2016-06-10 ) with deepin os (32 bit)

This bug is now verified as this bug fixed on latest firefox aurora 50.0a2 (20160908004007).

User Agent : Mozilla/5.0 (X11; Linux i686; rv:50.0) Gecko/20100101 Firefox/50.0.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.