1279683 - Restore the lost "Highlight All" feature in the find toolbar and persistence of the find result

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[B.J. Herbison]

Yesterday I could find a term in a page, press Highlight All, and scroll through the page looking at all the places that string occurred.

With the new Find toolbar (bug 384458) that feature is gone. Once I scroll or click on the page that is gone.

I can't even see where the found item was. I can't find a word in a block of text and go an copy the surrounding text because find in page no longer shows me where the found text was.

I used find-in-page/highlight-all daily and the feature is gone.

I will probably need to stop using Nightly for many tasks because of this, and stop using Firefox unless there is an extension to replace this new find-in-page.

Comment 1

[Marco Castelluccio [:marco]]

It doesn't disappear for me when I scroll, but it does disappear when I click. I agree this isn't a nice behavior.
AFAICS there's basically no difference now between selecting "Highlight all" or not.

Comment 2

[Mike de Boer [:mikedeboer]]

Setting the pref 'findbar.modalHighlight' to 'false' will turn off the feature and restore the old one.

Comment 3

[Markus Stange [:mstange]]

How are you scrolling the page? Are you using the scrollbar or the mouse wheel? I can confirm that dragging the scrollbar makes the overlay disappear, but when I scroll using the scroll wheel or my touchpad, then the overlay stays.

Comment 4

[B.J. Herbison]

I'm scrolling by dragging the scroll bar.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 6

[Sergio]

Auto-scroll "clicking middle/scroll mouse button" makes the overlay disappear too.

Comment 7

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 8

[Andrew Overholt [:overholt]]

Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).

Comment 9

[Albert Scheiner [:alberts]]

Will this bug cover general view port activation that makes the "Highlight all" disappear? Or will it target cases related to scrolling specifically? I was about to file a bug for the case when you simple click anywhere within the viewport to give the main content area focus, or to mark one of the found, highlighted strings.

Ones the dimmed overlay and the highlighting has been lost, it is almost impossible to restore it with the current string in the findbar. One way to get re-activate the "highlight all" is to change the search string. For example if I searched for "month" in this page, click into the content area, loose focus and delete the "h" I will get highlighting for "mont".
Another option is to iterate with arrow buttons ("find next") one time over _all_ matches, that will bring then highlighting back one-by-one.
One time only during my testing the dimming + highlighting was reinstated by pressing "Highlight All" twice, but I wasn't able to reproduce it every since I reloaded the page again.

I would assume that the dimming of the page for just "Find" or "Highlight All" would not change by focusing the viewport at all, but stay until the search bar is closed!?