1279685 - New find toolbar doesn't work very well when search results are hidden in a carousel

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Marco Castelluccio [:marco]]

It's hard to describe, see the screenshot: https://bug384458.bmoattachments.org/attachment.cgi?id=8762238.

There are a few problems:
1) The search result is highlighted in the middle of nowhere;
2) The page is enlarged, making a scrollbar appear;
3) Some parts of the page are not dimmed.

Comment 1

[B.J. Herbison]

Items 2 and 3 are problems, but I'm not sure item 1 is a problem. I think it's an improvement over the previous search in that you know the text is somewhere and you have a chance of finding it.

The placement of the highlighted text could be improved.

Comment 3

[Zaggy1024]

In my opinion, it doesn't really make sense to highlight a result that can't be scrolled to properly as is the case with many things using overflow:hidden. If you can't see it you have no idea what it's matching, and will force you to skip through a number of results that you can't see, therefore making it quite likely you'll overshoot skipping them and have to use the previous button to get back.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 5

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 6

[Andrew Overholt [:overholt]]

Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).