Closed Bug 1279690 Opened 3 years ago Closed 3 years ago

always allowReorder

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → longsonr
Attachment #8762277 - Flags: review?(cam) → review+
Attachment #8762277 - Attachment is obsolete: true
Comment on attachment 8763447 [details] [diff] [review]
fix backwards compatibility issues too

I think I should split the return first child part into a separate patch to land first. That's a preexisting bug that the existing reftests catch once everything is allowReorder. I.e. if there's no systemLanguage at all then we've a standard non-reorderable switch and we need to take the first item, not the last. Does that seem good to you Daniel?
Attachment #8763447 - Flags: review?(dholbert)
Comment on attachment 8763447 [details] [diff] [review]
fix backwards compatibility issues too

Review of attachment 8763447 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I agree this would be best split into two pieces (with the defaultChild tweak in its own patch)

r=me on both pieces.
Attachment #8763447 - Flags: review?(dholbert) → review+
Keywords: leave-open
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3bb5dd8a5a3
Part 1 - switch allowReorder should choose the first possible match. r=dholbert
Keywords: leave-open
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe25a30fcbb
Part 2 - switch should always allowReorder. r=cam, r=dholbert
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/fbe25a30fcbb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.