1279690 - always allowReorder

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: allowReorder="yes" always

See https://lists.w3.org/Archives/Public/www-svg/2016Jun/0003.html

Comment 2

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3af2ca72ac84

Comment 3

[Robert Longson [:longsonr]]

Attachment: fix backwards compatibility issues too

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f83024488464

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 8763447 [details] [diff] [review]
fix backwards compatibility issues too

I think I should split the return first child part into a separate patch to land first. That's a preexisting bug that the existing reftests catch once everything is allowReorder. I.e. if there's no systemLanguage at all then we've a standard non-reorderable switch and we need to take the first item, not the last. Does that seem good to you Daniel?

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8763447 [details] [diff] [review]
fix backwards compatibility issues too

Review of attachment 8763447 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I agree this would be best split into two pieces (with the defaultChild tweak in its own patch)

r=me on both pieces.

Comment 7

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef7ffc753a3b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3bb5dd8a5a3
Part 1 - switch allowReorder should choose the first possible match. r=dholbert

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3bb5dd8a5a3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe25a30fcbb
Part 2 - switch should always allowReorder. r=cam, r=dholbert

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fbe25a30fcbb

Comment 12

[Florian Scholz (Open Web Docs)]

Added notes to
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/switch
https://developer.mozilla.org/en-US/Firefox/Releases/50#SVG