Closed
Bug 1279690
Opened 8 years ago
Closed 8 years ago
always allowReorder
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
3.64 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
See https://lists.w3.org/Archives/Public/www-svg/2016Jun/0003.html
Attachment #8762277 -
Flags: review?(cam)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → longsonr
|
||
Updated•8 years ago
|
Attachment #8762277 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3af2ca72ac84
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8762277 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f83024488464
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8763447 [details] [diff] [review] fix backwards compatibility issues too I think I should split the return first child part into a separate patch to land first. That's a preexisting bug that the existing reftests catch once everything is allowReorder. I.e. if there's no systemLanguage at all then we've a standard non-reorderable switch and we need to take the first item, not the last. Does that seem good to you Daniel?
Attachment #8763447 -
Flags: review?(dholbert)
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8763447 [details] [diff] [review] fix backwards compatibility issues too Review of attachment 8763447 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, I agree this would be best split into two pieces (with the defaultChild tweak in its own patch) r=me on both pieces.
Attachment #8763447 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef7ffc753a3b
|
|
Assignee | |
Updated•8 years ago
|
Keywords: leave-open
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3bb5dd8a5a3 Part 1 - switch allowReorder should choose the first possible match. r=dholbert
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b3bb5dd8a5a3
|
|
Assignee | |
Updated•8 years ago
|
Keywords: leave-open
|
||
Comment 10•8 years ago
|
||
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe25a30fcbb Part 2 - switch should always allowReorder. r=cam, r=dholbert
|
|
Assignee | |
Updated•8 years ago
|
Keywords: dev-doc-needed
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fbe25a30fcbb
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Comment 12•7 years ago
|
||
Added notes to https://developer.mozilla.org/en-US/docs/Web/SVG/Element/switch https://developer.mozilla.org/en-US/Firefox/Releases/50#SVG
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•