1279704 - Highlighted word has an extra space after stylized characters

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Fanolian]

Attachment: findbar_stylized.html

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160611030214

Steps to reproduce:

1. Open attached testcase.
2. Search for "testcase" (without quote).


Actual results:

An extra space between T and C for the highlighted item.
There is no extra spaces if I manually add a space after stylized characters. (4th line, search for "test case")

p.s. Some highlighted words are stylized but stylized too much. See <b> or <code>.

Comment 1

[Pascal Chevrel:pascalc]

confirmed

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 3

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 4

[Andrew Overholt [:overholt]]

Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).

Comment 5

[Justin Dolske [:Dolske]]

Seems this is due to us drawing multiple boxes for the currently-found work, and those boxes pick up the default padding. When using multiple boxes we probably want to set left/right padding to 0.

Comment 7

[Mike de Boer [:mikedeboer]]

This will be fixed by bug 1305033.

Comment 8

[B.J. Herbison]

Bug 1305033 is verified fixed. Should this bug be tested and closed?

Comment 9

[Mike de Boer [:mikedeboer]]

I checked the attached (visual) test case and I agree it looks fixed.
Fanolian, please feel free to re-open if you feel otherwise!

Comment 10

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 50.0a1 (2016.06.11) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 52.0b2 on Win 8.1 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.