1279707 - the highlight will be accumulated and accumulated...

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps To Reproduce:
1. Open a page (e.g. https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Tabbed_browser )
2. Ctrl+F to open FindBar and input word ("browser") and hit ENTER
3. Click a link (e.g. "load listener" )
4. Select textfield of Findbar and Hit ENTER

Actual Results:
the new Find highlight is wrong

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 2

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 3

[Andrew Overholt [:overholt]]

Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).

Comment 4

[Mike de Boer [:mikedeboer]]

This should be working as expected now. If not, please re-open this bug. Thanks!

Comment 5

[roxleitan]

Verified this on Nightly 51.0a1, build ID:20160914030200, on Windows 10 x64 and Windows 7 x64 and I could not reproduce it with the term searched in the Description of the bug, but the issue is reproducible when searching for " to".

Reopening the bug.

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1279707 - when the location changes, we need to be more thorough in clearing the state variables than we are now to make sure we start fresh in new documents.

Review commit: https://reviewboard.mozilla.org/r/79006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79006/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8791627 [details]
Bug 1279707 - when the location changes, we need to be more thorough in clearing the state variables than we are now to make sure we start fresh in new documents.

https://reviewboard.mozilla.org/r/79006/#review77618

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7acbdb1d9a6
when the location changes, we need to be more thorough in clearing the state variables than we are now to make sure we start fresh in new documents. r=jaws

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7acbdb1d9a6

Comment 10

[roxleitan]

Verified as fixed (using the steps from the description) using the latest Nightly 52.0a1 Build ID:20160928030201 on Windows 10 X64 and Ubuntu 14.04.

I can still see some blank empty spaces if searching for "to" but that should be covered in bug 1302470. 
Considering the above, setting the status to verified fixed.