Closed
Bug 1279781
Opened 9 years ago
Closed 8 years ago
Make mach build faster work for Thunderbird
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
gps
:
review-
|
Details | Diff | Splinter Review |
I'd appreciate if we could include a quick hack for making mach build faster work with Thunderbird.
The problem is that the repackage target is called in the wrong directory since MOZ_BUILD_APP is ../mail. A quick workaround would be to use $(notdir $(MOZ_BUILD_APP)) which would do nothing to "browser", but clean up "../mail" to "mail".
From reading the TODO comment, the code is slated to go away anyway, so this won't be permanent.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8762373 -
Flags: review?(gps)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8762373 [details] [diff] [review]
Fix - v1
Review of attachment 8762373 [details] [diff] [review]:
-----------------------------------------------------------------
This seems acceptable.
Attachment #8762373 -
Flags: review?(gps) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8762373 [details] [diff] [review]
Fix - v1
Review of attachment 8762373 [details] [diff] [review]:
-----------------------------------------------------------------
Actually, no. Since "mobile/android" won't be pleased.
Attachment #8762373 -
Flags: review+ → review-
|
|
Assignee | |
Comment 4•8 years ago
|
||
I'm going to prefer fixing this using bug 1366607 where it will work out of the box (mostly)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•