Closed
Bug 1279865
Opened 8 years ago
Closed 8 years ago
[webvtt] fix html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bechen, Assigned: bechen)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59274/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59274/
Attachment #8762799 -
Flags: review?(giles)
Attachment #8762800 -
Flags: review?(giles)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59276/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59276/
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8762799 [details] Bug 1279865 - Enable html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html. https://reviewboard.mozilla.org/r/59274/#review56364
Attachment #8762799 -
Flags: review?(giles) → review+
|
|
||
Updated•8 years ago
|
Attachment #8762800 -
Flags: review?(giles) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8762800 [details] Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. https://reviewboard.mozilla.org/r/59276/#review56368 It is better to have the first line of the commit message be a short summary of *what* is changed in the patch, with details on separate lines below.
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8762799 [details] Bug 1279865 - Enable html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59274/diff/1-2/
Attachment #8762800 -
Attachment description: Bug 1279865 - 1. If mHasUserInteraction MediaElement is false, don't run the TimeMarchesOn because the element is not played. 2. Update the activeCueList only in TimeMarchesOn(). 3. run TimeMarchesOn() at the beginning of play. → Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played.
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8762800 [details] Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59276/diff/1-2/
|
||
Updated•8 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8762799 [details] Bug 1279865 - Enable html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59274/diff/2-3/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8762800 [details] Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59276/diff/2-3/
|
|
Assignee | |
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/59276/#review58090 ::: dom/html/TextTrackManager.cpp:542 (Diff revision 3) > if (mMediaElement && > - (!(mMediaElement->GetPlayedOrSeeked()) || mMediaElement->Seeking())) { > + (!(mMediaElement->GetPlayedOrSeeked()) || mMediaElement->Seeking() > + || !mMediaElement->GetHasUserInteraction())) { > return; I miss the autoplay case, so the test_webvtt_empty_displaystate.html failed.
|
|
Assignee | |
Comment 10•8 years ago
|
||
Comment on attachment 8762799 [details] Bug 1279865 - Enable html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59274/diff/3-4/
|
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8762800 [details] Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59276/diff/3-4/
|
|
Assignee | |
Comment 12•8 years ago
|
||
Comment on attachment 8762800 [details] Bug 1279865 - Don't run TimeMarchesOn if the MediaElement is not played. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59276/diff/4-5/
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 13•8 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/add8122d11a8 Enable html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html. r=rillian https://hg.mozilla.org/integration/mozilla-inbound/rev/57cf7cae92f1 Don't run TimeMarchesOn if the MediaElement is not played. r=rillian
Keywords: checkin-needed
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/add8122d11a8 https://hg.mozilla.org/mozilla-central/rev/57cf7cae92f1
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•