1279906 - NULL update notification displayed on OS X 10.6-10.8

Status: RESOLVED DUPLICATE of bug 1285639

(Toolkit :: Application Update, defect)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: null update available.png

[Affected versions]:
- outdated Dev Edition and Nightly

[Affected platforms]:
- OS X 10.6 - 10.8

[Steps to reproduce]:
1. Open any outdated version of Dev Edition or Nightly with a new profile (i.e. 45.0a1, 47.0a2)
2. Wait

[Expected result]:
- "No updates available" notification displayed

[Actual result]:
- Firefox (null) available

[Regression range]:
- not a regression, reproduced on Nightly 37.0a1

Comment 1

[Liz Henry (:lizzard)]

Robert, what do you think, should we care about cleaning this up? 
Dolske, do you want this info box to look nicer for out of date versions?

Comment 2

[Benjamin Smedberg]

For 10.6-10.8 in particular there's nothing we can do about this on the client since we've already shipped those clients. We could still make changes so that when this happens in the future we have a better experience.

I don't know whether we can change this on the AUS side: perhaps the snippet we're publishing is incorrect?

Comment 3

[Justin Dolske [:Dolske]]

I'm not sure what the update notification is supposed to show here (rstrong?) -- at first glance comment 0 is right, but it actually seems like we shouldn't even be showing a "no updates available" notification. So I think the expected results would be to show _nothing_, or to show something about "hey your platform is now unsupported" (but I don't know if we can actually do that).

Comment 4

[Liz Henry (:lizzard)]

Ben can you follow up to check on the AUS question from comment 2?

Comment 5

[[e-mail] (:bhearsum)]

The dialog in the screenshot doesn't look like the update dialog to me - it looks like a notification. I suspect that if it's clicked into, it will show something with the desupported inforrmation from https://support.mozilla.org/kb/firefox-osx on it.

I suspect Robert can provide more information, though.

Comment 6

[Paul Silaghi, QA [:pauly]]

(In reply to Ben Hearsum (:bhearsum) from comment #5)
> I suspect that if it's clicked into, it will show
> something with the desupported inforrmation
exactly

Comment 7

[Robert Strong (they/them - no direct email)]

Sorry for not responding sooner, I've been on PTO.

Paul, could you set the app.update.log pref to true, try to reproduce, and provide the value in the Browser Console that starts with
AUS:SVC Checker:checkForUpdates - sending request to:

Thanks!

Comment 8

[Paul Silaghi, QA [:pauly]]

AUS:SVC Checker:checkForUpdates - sending request to: https://aus5.mozilla.org/update/3/Firefox/47.0a2/20160425004018/Darwin_x86-gcc3-u-i386-x86_64/en-US/aurora/Darwin%2010.8.0/default/default/update.xml

Comment 9

[Robert Strong (they/them - no direct email)]

Ben, I think we ran into this when unsupported was first used but my memory isn't clear on this. To fix this you can add displayVersion to the unsupported update xml.

Comment 10

[[e-mail] (:bhearsum)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> Ben, I think we ran into this when unsupported was first used but my memory
> isn't clear on this. To fix this you can add displayVersion to the
> unsupported update xml.

I'll be doing this in bug 1285639. We're in the middle of transition to new infrastructure though, so it probably cannot be deployed for at least a week.

Comment 11

[[e-mail] (:bhearsum)]

Paul, can you give this a try again? I just deployed some changes to the update server that should fix this.

Comment 12

[Paul Silaghi, QA [:pauly]]

Attachment: after changes

The update notification is still displayed, but it no longer contains the NULL word. Clicking it, it will show the desupported information.

Comment 13

[Robert Strong (they/them - no direct email)]

Fixed by bug 1285639