1279947 - -about:b2g-installer not reachable since v50.0a1

Status: RESOLVED FIXED

Description

[Novski]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

i clicked in the URL bar and wrote: "about:b2g-installer" and it didn't apear like in version 49.0a1.  


Actual results:

cold not find site is writen in the window below url bar.


Expected results:

it normaly opens the b2g-installer to flash a device. (the page with the rocket) :-)

Comment 1

[Alexandre LISSY :gerard-majax]

Created attachment 8762738 [details]
JS Console

Comment 2

[Alexandre LISSY :gerard-majax]

Ok it's a trivial bug :)

Comment 3

[Alexandre LISSY :gerard-majax]

Since I would really like to onboard more people on the addon, I'd like that some contributors do fix this :)

Comment 4

[Alexandre LISSY :gerard-majax]

Masahiko or Jovan, the problem lies within bootstrap.js around the dump() call in startup(). For some reason, this used to work but now the conversion to fails. Surrounding this with a try/catch does the job.

This is a good first bug, would you be willing to take it, send a PR and make sure tests are okay after? Thanks!

Comment 5

[Jovan Gerodetti]

how can I enable debug logging? dump() should show up in the browser console? Right now neither dump() or console.log() show up.

Comment 6

[Alexandre LISSY :gerard-majax]

dump() should show, but check the js console not the webconsole. Start your firefox with "-jsconsole" :)

Comment 7

[Jovan Gerodetti]

>  for (var p in data) {
>    dump("data." + p + '\n');
>    dump("data." + p + "=" + data[p] + "\n");
>  }

every property of data is dumped to the console, but data.instanceID can't be stringified for some reason... how should we handle this?

Comment 8

[Jovan Gerodetti]

Created attachment 8762882 [details] [review]
TitanNano:Bug_1279947 > mozilla-b2g:master

Comment 9

[Alexandre LISSY :gerard-majax]

I'm not sure we really care

Comment 10

[Alexandre LISSY :gerard-majax]

Comment on attachment 8762882 [details] [review]
TitanNano:Bug_1279947 > mozilla-b2g:master

it's good but we could probably do more simply:
if (data[p] && data[p].toString) {
  dump("data." + p + "=" + data[p] + "\n");
} else {
  dump("data." + p + " cannot be dumped as a string\n");
}

Comment 11

[Jovan Gerodetti]

How about this?

>     let value = null;
>    
>     if (data[p] && data[p].toString) {
>       value = "=" + data[p].toString();
>     } else {
>       value = " cannot be dumped as a string\n");
>     }
>
>     dump("data." + p + value + "\n");


We need the explicit call to .toString() because that makes it possible to get a string representation of the symbol "Symbol([e-mail])" and not an exception.
 
I also don't quite understand why you want the dump(...) line twice.

Comment 12

[Alexandre LISSY :gerard-majax]

good for me this way :)

Comment 13

[Jovan Gerodetti]

ok updated the PR, you can merge.

Comment 14

[Alexandre LISSY :gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/6c49e640dbd307b37b67498009632d58dd8acd5b

Comment 15

[Alexandre LISSY :gerard-majax]

Thanks!

Comment 16

[Alexandre LISSY :gerard-majax]

Do you have a linux 64 and a mac 64 ? If so, would you mind doing a new release ? If not I'll do it but I don't have much time.

Comment 17

[Jovan Gerodetti]

yes I have both, but I'd like to wait until we fix Bug 1275063, so we can re-submit to AMO.