WebGLRenderingContext methods accepting ArrayBufferView do not work with SharedArrayBuffer

RESOLVED FIXED in Firefox 50

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: spectralcanine, Assigned: ethlin)

Tracking

47 Branch
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

Use WebGLRenderingContext.uniform* methods, with the last argument being a view of a SharedArrayBuffer.


Actual results:

Error: WebGL: uniformMatrix4fv: expected an array of length a multiple of 16, got an array of length 0.
Jeff, I believe this falls into your bucket.
Flags: needinfo?(jgilbert)
Component: Untriaged → Canvas: WebGL
Flags: needinfo?(jgilbert)
Product: Firefox → Core
Flags: needinfo?(howareyou322)
Whiteboard: [gfx-noted]

Comment 2

2 years ago
Ethan, please help on this.
Assignee: nobody → ethlin
Flags: needinfo?(howareyou322)
(Assignee)

Comment 3

2 years ago
Created attachment 8764092 [details] [diff] [review]
allow SharedArrayBuffer

Make Uniform*, UniformMatrix* and VertexAttrib* accept SharedArrayBuffer.
Attachment #8764092 - Flags: review?(jgilbert)
Attachment #8764092 - Flags: review?(jgilbert) → review+
(Assignee)

Updated

2 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 4

2 years ago
Created attachment 8772661 [details] [diff] [review]
allow SharedArrayBuffer (carry r+: jgilbert)

Rebase the patch.
Attachment #8764092 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e23273bf350
Make WebGL Uniform*, UniformMatrix* and VertexAttrib* accept SharedArrayBuffer. r=jgilbert
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6e23273bf350
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.