Closed Bug 1279986 Opened 8 years ago Closed 8 years ago

WebGLRenderingContext methods accepting ArrayBufferView do not work with SharedArrayBuffer

Categories

(Core :: Graphics: CanvasWebGL, defect)

47 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: spectralcanine, Assigned: ethlin)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

Use WebGLRenderingContext.uniform* methods, with the last argument being a view of a SharedArrayBuffer.


Actual results:

Error: WebGL: uniformMatrix4fv: expected an array of length a multiple of 16, got an array of length 0.
Jeff, I believe this falls into your bucket.
Flags: needinfo?(jgilbert)
Component: Untriaged → Canvas: WebGL
Flags: needinfo?(jgilbert)
Product: Firefox → Core
Flags: needinfo?(howareyou322)
Whiteboard: [gfx-noted]
Ethan, please help on this.
Assignee: nobody → ethlin
Flags: needinfo?(howareyou322)
Attached patch allow SharedArrayBuffer (obsolete) — Splinter Review
Make Uniform*, UniformMatrix* and VertexAttrib* accept SharedArrayBuffer.
Attachment #8764092 - Flags: review?(jgilbert)
Attachment #8764092 - Flags: review?(jgilbert) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Rebase the patch.
Attachment #8764092 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e23273bf350
Make WebGL Uniform*, UniformMatrix* and VertexAttrib* accept SharedArrayBuffer. r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6e23273bf350
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: