Closed Bug 1280006 Opened 4 years ago Closed 4 years ago

Backout image cache double-key.

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jhao, Assigned: jhao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [userContextId][domsecurity-backlog][uplift49-])

Attachments

(3 files, 4 obsolete files)

The patch in bug 1270680 causes the regression in bug 1279099. We decided to back out that patch.
This reverts commit 8ef7edb6a790df9128558e6eb520701f4fc600a0.
Attachment #8762648 - Flags: review?(tanvi)
Actually in the bug description I meant "patches".

This reverts commit c3ca86b9a6a787a8d81331453f5ff064de096038.
Attachment #8762649 - Flags: review?(tanvi)
This reverts commit bb0482fe09fbfad9be89384ec5cb8b6518187379.
Attachment #8762650 - Flags: review?(tanvi)
Attachment #8762648 - Attachment is obsolete: true
Attachment #8762648 - Flags: review?(tanvi)
Attachment #8762649 - Attachment is obsolete: true
Attachment #8762649 - Flags: review?(tanvi)
Attachment #8762650 - Attachment is obsolete: true
Attachment #8762650 - Flags: review?(tanvi)
Attachment #8762655 - Flags: review?(tanvi) → review+
This reverts commit c3ca86b9a6a787a8d81331453f5ff064de096038.
Attachment #8762656 - Flags: review?(tanvi)
Attachment #8762654 - Attachment is obsolete: true
Attachment #8762654 - Flags: review?(tanvi)
Attachment #8762653 - Flags: review?(tanvi) → review+
Attachment #8762656 - Flags: review?(tanvi) → review+
Pushed by tvyas@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69f96df556e6
Backout "Bug 1270680 - Part 3 - Get origin attributes from loadInfo in LoadImageWithChannel()." r=tanvi
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb5956cb6cec
Backout "Bug 1270680 - Part 2: Tests that make sure image cache respect originAttributes." r=tanvi
https://hg.mozilla.org/integration/mozilla-inbound/rev/e94cc9fec841
Backout "Bug 1270680 - Part 1: Double-key the image cache by origin attribute." r=tanvi
https://hg.mozilla.org/mozilla-central/rev/69f96df556e6
https://hg.mozilla.org/mozilla-central/rev/bb5956cb6cec
https://hg.mozilla.org/mozilla-central/rev/e94cc9fec841
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
No longer blocks: 1279099
Depends on: 1279099
Duplicate of this bug: 1279099
This doesn't need to uplifted to 49 since the patch it backs out a patch that landed in 50 (not 49).
Whiteboard: [userContextId][domsecurity-backlog] → [userContextId][domsecurity-backlog][uplift49-]
You need to log in before you can comment on or make changes to this bug.