Closed
Bug 1280006
Opened 8 years ago
Closed 8 years ago
Backout image cache double-key.
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jhao, Assigned: jhao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [userContextId][domsecurity-backlog][uplift49-])
Attachments
(3 files, 4 obsolete files)
1.23 KB,
patch
|
tanvi
:
review+
|
Details | Diff | Splinter Review |
21.70 KB,
patch
|
tanvi
:
review+
|
Details | Diff | Splinter Review |
3.27 KB,
patch
|
tanvi
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 1270680 causes the regression in bug 1279099. We decided to back out that patch.
Assignee | ||
Comment 1•8 years ago
|
||
This reverts commit 8ef7edb6a790df9128558e6eb520701f4fc600a0.
Attachment #8762648 -
Flags: review?(tanvi)
Assignee | ||
Comment 2•8 years ago
|
||
Actually in the bug description I meant "patches". This reverts commit c3ca86b9a6a787a8d81331453f5ff064de096038.
Attachment #8762649 -
Flags: review?(tanvi)
Assignee | ||
Comment 3•8 years ago
|
||
This reverts commit bb0482fe09fbfad9be89384ec5cb8b6518187379.
Attachment #8762650 -
Flags: review?(tanvi)
Comment 4•8 years ago
|
||
It also causes https://bugzilla.mozilla.org/show_bug.cgi?id=1279519
Assignee | ||
Updated•8 years ago
|
Attachment #8762648 -
Attachment is obsolete: true
Attachment #8762648 -
Flags: review?(tanvi)
Assignee | ||
Updated•8 years ago
|
Attachment #8762649 -
Attachment is obsolete: true
Attachment #8762649 -
Flags: review?(tanvi)
Assignee | ||
Updated•8 years ago
|
Attachment #8762650 -
Attachment is obsolete: true
Attachment #8762650 -
Flags: review?(tanvi)
Updated•8 years ago
|
Attachment #8762655 -
Flags: review?(tanvi) → review+
Assignee | ||
Comment 8•8 years ago
|
||
This reverts commit c3ca86b9a6a787a8d81331453f5ff064de096038.
Attachment #8762656 -
Flags: review?(tanvi)
Assignee | ||
Updated•8 years ago
|
Attachment #8762654 -
Attachment is obsolete: true
Attachment #8762654 -
Flags: review?(tanvi)
Updated•8 years ago
|
Attachment #8762653 -
Flags: review?(tanvi) → review+
Updated•8 years ago
|
Attachment #8762656 -
Flags: review?(tanvi) → review+
Pushed by tvyas@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69f96df556e6 Backout "Bug 1270680 - Part 3 - Get origin attributes from loadInfo in LoadImageWithChannel()." r=tanvi https://hg.mozilla.org/integration/mozilla-inbound/rev/bb5956cb6cec Backout "Bug 1270680 - Part 2: Tests that make sure image cache respect originAttributes." r=tanvi https://hg.mozilla.org/integration/mozilla-inbound/rev/e94cc9fec841 Backout "Bug 1270680 - Part 1: Double-key the image cache by origin attribute." r=tanvi
Comment 10•8 years ago
|
||
backout bugherder |
https://hg.mozilla.org/mozilla-central/rev/69f96df556e6 https://hg.mozilla.org/mozilla-central/rev/bb5956cb6cec https://hg.mozilla.org/mozilla-central/rev/e94cc9fec841
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 years ago
|
This doesn't need to uplifted to 49 since the patch it backs out a patch that landed in 50 (not 49).
Whiteboard: [userContextId][domsecurity-backlog] → [userContextId][domsecurity-backlog][uplift49-]
You need to log in
before you can comment on or make changes to this bug.
Description
•