Closed Bug 1280064 Opened 4 years ago Closed 4 years ago

Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=813b05555a96
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Unbreak non-DEBUG builds.
Attachment #8762705 - Flags: review?(terrence)
Attachment #8762694 - Attachment is obsolete: true
Attachment #8762694 - Flags: review?(terrence)
Blocks: 1263289
Iteration: --- → 50.1
Flags: qe-verify-
Priority: -- → P1
Comment on attachment 8762705 [details] [diff] [review]
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Review of attachment 8762705 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Sorry for the late reviews on these. For some reason, bugzilla did not let me log in all last week, despite using what I've now verified was the right password.

::: js/src/jsgc.cpp
@@ +884,5 @@
>      inUnsafeRegion(0),
>      noGCOrAllocationCheck(0),
>      noNurseryAllocationCheck(0),
>  #endif
> +    lock(),

You should be able to just remove this line entirely, right?

::: js/src/jsgc.h
@@ +18,5 @@
>  
>  #include "js/GCAPI.h"
>  #include "js/SliceBudget.h"
>  #include "js/Vector.h"
>  

Remove this line-break while you are here, please.
Attachment #8762705 - Flags: review?(terrence) → review+
Iteration: 50.1 → 50.2
Whiteboard: [devtools-html]
Blocks: 956899
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c36f5c0bed2c
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState; r=terrence
https://hg.mozilla.org/mozilla-central/rev/c36f5c0bed2c
https://hg.mozilla.org/mozilla-central/rev/b46f11f21ce3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Whiteboard: [devtools-html]
You need to log in before you can comment on or make changes to this bug.