1280064 - Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=813b05555a96

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Unbreak non-DEBUG builds.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2505eaefaf18

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8762705 [details] [diff] [review]
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState

Review of attachment 8762705 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Sorry for the late reviews on these. For some reason, bugzilla did not let me log in all last week, despite using what I've now verified was the right password.

::: js/src/jsgc.cpp
@@ +884,5 @@
>      inUnsafeRegion(0),
>      noGCOrAllocationCheck(0),
>      noNurseryAllocationCheck(0),
>  #endif
> +    lock(),

You should be able to just remove this line entirely, right?

::: js/src/jsgc.h
@@ +18,5 @@
>  
>  #include "js/GCAPI.h"
>  #include "js/SliceBudget.h"
>  #include "js/Vector.h"
>  

Remove this line-break while you are here, please.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c36f5c0bed2c
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState; r=terrence

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b46f11f21ce3
Address review nits; r=terrence

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c36f5c0bed2c
https://hg.mozilla.org/mozilla-central/rev/b46f11f21ce3