1280112 - Opening a link from Facebook Messenger chat head crashes Firefox (Android N)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[rqou]

User Agent: Mozilla/5.0 (Android N; Mobile; rv:48.0) Gecko/48.0 Firefox/48.0
Build ID: 20160607191837
Firefox for Android

Steps to reproduce:

1. (Possibly needed, uncertain) Be running Android N NPD35K
2. Have chat heads enabled in Facebook Messenger 
3. Have a friend send you a link via Facebook Messenger 
4. (Possibly needed, uncertain) Have Firefox be the app "under" the chat head when the chat head is expanded 
5. Tap on the received link


Actual results:

Animations play as if the page is about to open. Firefox then suddenly disappears and another app in the Android "app stack" replaces it. Reopening Firefox shows that all tabs are closed as if a crash occured. No crash dialog appears. Nothing is logged in about:crashes. 

This issue does not seem to happen if a link is tapped in Facebook Messenger launched "as a full app" rather than as a chat head.


Expected results:

The page should have loaded normally.

Comment 1

[Mike Taylor [:miketaylr]]

Kevin, does this repro for you? (I don't have access to an N device...)

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

I don't use Messenger. Maybe Sebastian?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I can reproduce this.

> 4. (Possibly needed, uncertain) Have Firefox be the app "under" the chat head when the chat head is expanded 

Yeah, this seems to be required. It happens when opening a link while the app is still technically in the foreground.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1280112 - LauncherActivity: Remove task flags from incoming intent.

Review commit: https://reviewboard.mozilla.org/r/76986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76986/

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8788508 [details]
Bug 1280112 - LauncherActivity: Remove task flags from incoming intent.

https://reviewboard.mozilla.org/r/76986/#review75216

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25ae9569214c
LauncherActivity: Remove task flags from incoming intent. r=ahunt

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/25ae9569214c

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

This seems to have fixed more issues (bug 1204424) - We should consider uplifting this.