1280134 - The Pocket toolbar icon in Linux uses low rez version on hidpi displays

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Eitan Isaacson [:eeejay]]

The amazingly tasteful pocket toolbar icon is fuzzy in Linux!

It looks like grabbing the windows or osx hidpi png should do the trick.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1280134 - Add hidpi toolbar icon for Pocket.

Review commit: https://reviewboard.mozilla.org/r/59258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59258/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8762769 [details]
Bug 1280134 - Add hidpi toolbar icon for Pocket.

https://reviewboard.mozilla.org/r/59258/#review56306

This too should be using the windows images if it isn't already, but see also below.

::: browser/extensions/pocket/skin/linux/pocket.css:13
(Diff revision 1)
> +  #pocket-button {
> +    list-style-image: url("chrome://pocket/skin/[e-mail]");
> +  }
> +
> +  toolbar[brighttext] #pocket-button {
> +    list-style-image: url("chrome://pocket/skin/[e-mail]");
> +  }
> +
> +  #pocket-button[cui-areatype="toolbar"] {
> +    -moz-image-region: rect(0, 36px, 36px, 0px);
> +  }

Please unify this with the Windows and OS X styling for everything except the 'open' state and stick it in the shared/ stylesheet instead.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: pocket-comparison.png

Here are all the versions side by side. The left most id Linux, and the second from left is the non-yosemite osx version. It is almost identical to the Linux one.

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 8762769 [details]
Bug 1280134 - Add hidpi toolbar icon for Pocket.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59258/diff/1-2/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8762769 [details]
Bug 1280134 - Add hidpi toolbar icon for Pocket.

https://reviewboard.mozilla.org/r/59258/#review59356

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6e8c3df9af3
Add hidpi toolbar icon for Pocket. r=Gijs

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/e6e8c3df9af3