1280179 - Typo in csp.properties

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Wim]

There is a closing qoute typo in:
https://hg.mozilla.org/mozilla-central/diff/b38b4072fd41/dom/locales/en-US/chrome/security/csp.properties#l1.14

‘%1$S‘ needs to be ‘%1$S’

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Wim from comment #0)
> ‘%1$S‘ needs to be ‘%1$S’

Thanks Wim for filing. What's the impact of this type actually? Is the console broken because of that?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1280179_typo_in_csp_properties.patch

Comment 3

[Wim]

Actually, I haven't tested the impact. I guess the console isn't that picky about the qoutes.

Comment 4

[Stephanie Ouillon [:arroway] (needinfo me)]

Comment on attachment 8762810 [details] [diff] [review]
bug_1280179_typo_in_csp_properties.patch

Review of attachment 8762810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. 
Is there any other file than https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_show_subresource_security_errors.js implementing tests for SRI in the webconsole

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Stephanie Ouillon [:arroway] from comment #4)
> Is there any other file than
> https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/
> test/browser_webconsole_show_subresource_security_errors.js implementing
> tests for SRI in the webconsole

I don't think so - thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df6eab7648cb
Fix type on csp.properties . r=arroway

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df6eab7648cb