1280200 - Convert toolkit/loader.js to use channel.open2()

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1280200_open2_loader_js.patch

Dietrich, any chance you could accept that? We are deprecating open and should be using open2() everywhere - thanks!

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 8762881 [details] [diff] [review]
bug_1280200_open2_loader_js.patch

Pass review to Gabor to review or pass along :)

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8762881 [details] [diff] [review]
bug_1280200_open2_loader_js.patch

Review of attachment 8762881 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. Don't forget to update the r= part in the comment of the patch.

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1280200_open2_loader_js.patch

updated reviewer to r=gkrizsanits

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a108d2c14737
Convert toolkit/loader.js to use channel.open2() r=gkrizsanits

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a108d2c14737