Closed Bug 1280200 Opened 3 years ago Closed 3 years ago

Convert toolkit/loader.js to use channel.open2()

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ckerschb
Blocks: 1182535
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Dietrich, any chance you could accept that? We are deprecating open and should be using open2() everywhere - thanks!
Attachment #8762881 - Flags: review?(dietrich)
Comment on attachment 8762881 [details] [diff] [review]
bug_1280200_open2_loader_js.patch

Pass review to Gabor to review or pass along :)
Attachment #8762881 - Flags: review?(dietrich) → review?(gkrizsanits)
Comment on attachment 8762881 [details] [diff] [review]
bug_1280200_open2_loader_js.patch

Review of attachment 8762881 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. Don't forget to update the r= part in the comment of the patch.
Attachment #8762881 - Flags: review?(gkrizsanits) → review+
updated reviewer to r=gkrizsanits
Attachment #8762881 - Attachment is obsolete: true
Attachment #8763492 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a108d2c14737
Convert toolkit/loader.js to use channel.open2() r=gkrizsanits
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a108d2c14737
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.