Closed
Bug 1280204
Opened 9 years ago
Closed 9 years ago
Convert devtools/client/shared/theme.js to use channel.open2()
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
934 bytes,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Comment 1•9 years ago
|
||
Brian, open() will be deprecated soon, just updating to use open2(). I suppose you are fine with accepting that, right?
Attachment #8762874 -
Flags: review?(bgrinstead)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8762874 [details] [diff] [review]
bug_1280204_test_theme_js_open2.patch
Review of attachment 8762874 [details] [diff] [review]:
-----------------------------------------------------------------
Sure, as long as tests all still pass
Attachment #8762874 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5511ed4a5d4a
Convert devtools/client/shared/theme.js to use channel.open2(). r=grinstead
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•