Closed Bug 1280216 Opened 8 years ago Closed 8 years ago

Remove nsIAboutModule::GetIndexedDBOriginPostfix()

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: janv, Assigned: janv)

Details

(Whiteboard: btpp-fixlater)

Attachments

(1 file, 1 obsolete file)

patch
12.20 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
The method was added in bug 1028187. It seems to me that Firefox Hello doesn't need it anymore, since it doesn't use IndexedDB anymore.
Mark, can you confirm Firefox Hello doesn't use IndexedDB anymore ? Thanks.
Flags: needinfo?(standard8)
This is probably fine, but Dan is likely to be able to comment for certainty.
Flags: needinfo?(standard8) → needinfo?(dmose)
Whiteboard: btpp-fixlater
Sounds fine to me.
Flags: needinfo?(dmose)
Assignee: nobody → standard8
I have actually a patch for this somewhere, let me find it.
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  
Jan, do you want to go ahead and get review and land this? The patch is pretty much what I'd have expected - you might need a minor bitrot update as we just landed the Hello removal.
Assignee: standard8 → jvarga
Flags: needinfo?(jvarga)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #8775100 -
        Attachment is obsolete: true
Flags: needinfo?(jvarga)

    
    

    
  
Comment on attachment 8779280 [details] [diff] [review]
patch

Boris, this is basically an undo of bug 1028187.

        Attachment #8779280 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 8779280 [details] [diff] [review]
patch

r=me.  Glad to see we're cleaning up this cruft...

        Attachment #8779280 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf62d80b77ea
Remove nsIAboutModule::GetIndexedDBOriginPostfix(); r=bz

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bf62d80b77ea
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox51:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: