Closed Bug 1280290 Opened 4 years ago Closed 4 years ago

Intermittent browser_notifications.js | leaked 1 docShell(s) until shutdown

Categories

(Toolkit :: Password Manager, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: philor, Assigned: rwood)

References

Details

(Keywords: intermittent-failure, Whiteboard: [passwords:capture-UI])

Attachments

(1 file)

Whiteboard: [passwords:capture-UI]
I'm attempting to green-up the mochitest-e10s browser-chrome tests on Win 7 VM debug, and this particular intermittent is happening much more frequent there. In this case, 4 times in 50 runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e42b9cde2d237368608a5bc2b14dae0180b6409d&filter-searchStr=bc3

I'm not really sure how to debug this, except to comment out parts of the test and run on try.

:rittme, I see your name in the test history, any ideas what in this test could be leaking docshells? Or suggestions for how I can debug? Thanks!
Flags: needinfo?(bernardo)
I split the test up into the three individual test cases, pushed each of those to try and retriggered 50x, and the intermittent didn't happen at all:

https://treeherder.mozilla.org/#/jobs?repo=try&author=rwood@mozilla.com&tochange=94fa416cea0c82ed68c10ec558a637893cb38486&fromchange=c03fa0bb0b28f82fdb377c029a509f65a3bfdaf6
good idea :rwood, you should run this on all platforms to make sure it is ok- then I would submit a patch for review :)
Comment on attachment 8782214 [details]
Bug 1280290 - Split test up to fix intermittent docshell leak;

https://reviewboard.mozilla.org/r/72418/#review70190

nice stuff
Attachment #8782214 - Flags: review?(jmaher) → review+
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbceeb3c8355
Split test up to fix intermittent docshell leak; r=jmaher
In the future please use an `hg copy` to preserve the blame when splitting files. A review from a peer would have also been good.
Flags: needinfo?(bernardo)
(In reply to Matthew N. [:MattN] from comment #9)
> In the future please use an `hg copy` to preserve the blame when splitting
> files. A review from a peer would have also been good.

Good point, ok thanks!
https://hg.mozilla.org/mozilla-central/rev/fbceeb3c8355
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → rwood
You need to log in before you can comment on or make changes to this bug.