1280290 - Intermittent browser_notifications.js | leaked 1 docShell(s) until shutdown

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P4)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=30172028&repo=mozilla-inbound

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1
* mozilla-beta: 1
* autoland: 1

Platform breakdown:
* windows7-32: 2
* osx-10-10: 2
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280290&startday=2016-08-01&endday=2016-08-07&tree=all

Comment 2

[Intermittent Failures Robot]

30 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 14
* mozilla-inbound: 7
* try: 4
* mozilla-beta: 2
* mozilla-central: 1
* mozilla-aurora: 1
* fx-team: 1

Platform breakdown:
* windows7-32: 23
* windows8-64: 2
* osx-10-10: 2
* linux32: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280290&startday=2016-08-08&endday=2016-08-14&tree=all

Comment 3

[Robert Wood [:rwood]]

I'm attempting to green-up the mochitest-e10s browser-chrome tests on Win 7 VM debug, and this particular intermittent is happening much more frequent there. In this case, 4 times in 50 runs:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e42b9cde2d237368608a5bc2b14dae0180b6409d&filter-searchStr=bc3

I'm not really sure how to debug this, except to comment out parts of the test and run on try.

:rittme, I see your name in the test history, any ideas what in this test could be leaking docshells? Or suggestions for how I can debug? Thanks!

Comment 4

[Robert Wood [:rwood]]

I split the test up into the three individual test cases, pushed each of those to try and retriggered 50x, and the intermittent didn't happen at all:

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&tochange=94fa416cea0c82ed68c10ec558a637893cb38486&fromchange=c03fa0bb0b28f82fdb377c029a509f65a3bfdaf6

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

good idea :rwood, you should run this on all platforms to make sure it is ok- then I would submit a patch for review :)

Comment 6

[Robert Wood [:rwood]]

Attachment: Bug 1280290 - Split test up to fix intermittent docshell leak;

Review commit: https://reviewboard.mozilla.org/r/72418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72418/

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8782214 [details]
Bug 1280290 - Split test up to fix intermittent docshell leak;

https://reviewboard.mozilla.org/r/72418/#review70190

nice stuff

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbceeb3c8355
Split test up to fix intermittent docshell leak; r=jmaher

Comment 9

[Matthew N. [:MattN]]

In the future please use an `hg copy` to preserve the blame when splitting files. A review from a peer would have also been good.

Comment 10

[Robert Wood [:rwood]]

(In reply to Matthew N. [:MattN] from comment #9)
> In the future please use an `hg copy` to preserve the blame when splitting
> files. A review from a peer would have also been good.

Good point, ok thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fbceeb3c8355

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e4499ae0f81

Comment 13

[Intermittent Failures Robot]

18 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 9
* mozilla-inbound: 4
* try: 3
* mozilla-beta: 2

Platform breakdown:
* windows7-32: 14
* windows8-64: 2
* windows7-32-vm: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280290&startday=2016-08-15&endday=2016-08-21&tree=all

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/636668cfe497