remove MOZ_HAVE_REF_QUALIFIERS

RESOLVED FIXED in Firefox 53

Status

()

Core
MFBT
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Once we depend on msvc2015, all of our supported compilers support this, so we can get rid of the conditional code.
(Assignee)

Updated

2 years ago
Blocks: 1280296
Created attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Now that we require VS2015 (bug 1186064) and gcc >= 4.8.5 (bug 1175546), we can use reference qualifiers.
Attachment #8774074 - Flags: review?(nfroyd)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Review of attachment 8774074 [details] [diff] [review]:
-----------------------------------------------------------------

The minimum 4.8.0 requirement (cf. mfbt/Compiler.h) is not the same thing as requiring 4.8.1 for this feature, yes?
Attachment #8774074 - Flags: review?(nfroyd)
Note the canonical compiler version check is in build/moz.configure/toolchain.configure, not mfbt/Compiler.h.
Oops. Thanks. I was confused by bug 1175546, which bumped the minimum GCC version to 4.8.5 in some files:

https://bugzilla.mozilla.org/show_bug.cgi?id=1175546#c17

https://hg.mozilla.org/mozilla-central/rev/2d59367c985a
Depends on: 1175546
Depends on: 1322792
No longer depends on: 1175546
Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Now that we require gcc 4.9 (bug 1322792), we can remove MOZ_HAVE_REF_QUALIFIERS and use reference qualifiers.
Attachment #8774074 - Flags: review?(nfroyd)
(Assignee)

Updated

a year ago
Attachment #8774074 - Flags: review?(nfroyd) → review+
status-firefox50: --- → wontfix
status-firefox51: --- → wontfix
status-firefox52: --- → wontfix
status-firefox53: --- → affected
Priority: -- → P3

Comment 6

a year ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ee681bcb6c
Remove MOZ_HAVE_REF_QUALIFIERS. r=froydnj

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/49ee681bcb6c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.