Closed Bug 1280295 Opened 4 years ago Closed 3 years ago

remove MOZ_HAVE_REF_QUALIFIERS

Categories

(Core :: MFBT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Once we depend on msvc2015, all of our supported compilers support this, so we can get rid of the conditional code.
Blocks: 1280296
Now that we require VS2015 (bug 1186064) and gcc >= 4.8.5 (bug 1175546), we can use reference qualifiers.
Attachment #8774074 - Flags: review?(nfroyd)
Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Review of attachment 8774074 [details] [diff] [review]:
-----------------------------------------------------------------

The minimum 4.8.0 requirement (cf. mfbt/Compiler.h) is not the same thing as requiring 4.8.1 for this feature, yes?
Attachment #8774074 - Flags: review?(nfroyd)
Note the canonical compiler version check is in build/moz.configure/toolchain.configure, not mfbt/Compiler.h.
Oops. Thanks. I was confused by bug 1175546, which bumped the minimum GCC version to 4.8.5 in some files:

https://bugzilla.mozilla.org/show_bug.cgi?id=1175546#c17

https://hg.mozilla.org/mozilla-central/rev/2d59367c985a
Depends on: gcc-4.8
Depends on: 1322792
No longer depends on: gcc-4.8
Comment on attachment 8774074 [details] [diff] [review]
remove-MOZ_HAVE_REF_QUALIFIERS.patch

Now that we require gcc 4.9 (bug 1322792), we can remove MOZ_HAVE_REF_QUALIFIERS and use reference qualifiers.
Attachment #8774074 - Flags: review?(nfroyd)
Attachment #8774074 - Flags: review?(nfroyd) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ee681bcb6c
Remove MOZ_HAVE_REF_QUALIFIERS. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/49ee681bcb6c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.