Closed Bug 1280336 Opened 6 years ago Closed 6 years ago

b2g-installer broke indexedDB

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jovan.gerodetti, Assigned: janv)

References

Details

Attachments

(2 files)

After installing the b2g-installer add-on it is impossible to open any indexedDB anymore. 

> Quota 'about' is not a valid schema!: ActorsParent.cpp:6678 
> Quota Origin 'about+b2g-installer' failed to parse, handled tokens: : ActorsParent.cpp:6598

the open() call returns the following error:

> The operation failed for reasons unrelated to the database itself and not covered by any other error code.

Uninstalling the add-on does not fix the problem.

Who can help to fix this?
Flags: needinfo?(lissyx+mozillians)
Component: General → DOM: IndexedDB
Product: Firefox → Core
Well I have no idea at all :/
Flags: needinfo?(lissyx+mozillians)
I guess we need to play with URI_SAFE_FOR_UNTRUSTED_CONTENT, see netwerk/test/unit/test_about_protocol.js
Jan, Yoshi, can you help?
Flags: needinfo?(jvarga)
Flags: needinfo?(allstars.chh)
I'll take a look.
Can someone zip his <profile>/storage/?/about+bg2-installer and attach it to this bug ?
Thanks.

I managed to launch about:b2g-installer, but I don't have a supported device by hand.
Note bug 1228118 comment 1. Maybe :sicking can help.
See Also: → 1228118
(also bug 1253673 - so maybe behaviour is different when comparing 47 vs. 48+)
Attachment #8763044 - Flags: feedback?(jvarga)
Ok, so it's the DOM cache that writes something for about:b2g-installer.
This should be easy to fix.
Flags: needinfo?(jvarga)
Assignee: nobody → jvarga
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Selfish request: if we can fix this in a way which addresses bug 1228118 comment #1 so that removing moz-safe-about becomes easier, that would be really useful. :-)
Attached patch patchSplinter Review
Flags: needinfo?(allstars.chh)
Attachment #8763048 - Flags: review?(bugmail)
Attachment #8763044 - Flags: feedback?(jvarga)
(In reply to Jan Varga [:janv] from comment #14)
> Created attachment 8763048 [details] [diff] [review]
> patch

That's much more complex :)
Attachment #8763048 - Flags: review?(bugmail) → review+
(In reply to Jan Varga [:janv] from comment #15)
> (In reply to Jan Varga [:janv] from comment #14)
> > Created attachment 8763048 [details] [diff] [review]
> > patch
> 
> That's much more complex :)

clicked on wrong "reply" :)
I wanted to say that the "moz-safe-about' elimination is much more complex.
(In reply to Jan Varga [:janv] from comment #16)
> (In reply to Jan Varga [:janv] from comment #15)
> > (In reply to Jan Varga [:janv] from comment #14)
> > > Created attachment 8763048 [details] [diff] [review]
> > > patch
> > 
> > That's much more complex :)
> 
> clicked on wrong "reply" :)
> I wanted to say that the "moz-safe-about' elimination is much more complex.

Right, but based on this patch, if page about:foo used to be stored with moz-safe-about:foo and were to now request with about:foo, am I right in thinking that would now work (ie find the moz-safe-about-based-stored-data) ? If so, that'll make eliminating moz-safe-about much easier on the protocol/netwerk side. Sorry if that's a stupid question!
Flags: needinfo?(jvarga)
I guess there was no moz-safe-about:b2g-installer before. I think this add-on is rather new and the problem appeared when the .metadata file got lost for that directory (in that case we have to parse the origin directory name). That doesn't happen so often, that's why the bug appeared just now I believe.
Flags: needinfo?(jvarga)
https://hg.mozilla.org/mozilla-central/rev/781990193010
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Jovan, we should update the firefox version checking in the addon now :)
Flags: needinfo?(titannanomail)
yes I can file a bug for that. Should we remove it completely?
Flags: needinfo?(titannanomail) → needinfo?(lissyx+mozillians)
Let's keep it, I prefer that we are more strict than less. Unexpected behaviors can lead to devices badly flashed :/
Flags: needinfo?(lissyx+mozillians)
You need to log in before you can comment on or make changes to this bug.