Closed
Bug 1280369
Opened 9 years ago
Closed 9 years ago
Fennec crashes when SyncResumeResizeCompositor is called without a valid java surface
Categories
(Firefox for Android Graveyard :: Toolbar, defect, P3)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: droeh, Assigned: droeh)
References
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
This just adds a check for surface validity to GLController.resumeCompositor, which should stop us from hitting SyncResumeResizeCompositor with an invalid surface.
Attachment #8763027 -
Flags: review?(snorp)
Attachment #8763027 -
Flags: review?(snorp) → review+
I think we want to refactor this a little bit, but this should fix the remaining crash.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Yeah, I figured it's best to just fix the crash as simply as possible and deal with refactoring as I kill GLController.
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a3e9e3b9991
Check surface validity in GLController.resumeCompositor r=snorp
|
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Comment 6•9 years ago
|
||
Defaulting this to a P3 since there's no context given in comment 0 and no linked bugs so I have no idea how important this is.
Priority: -- → P3
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•